bugGNUstep - Bugs: bug #52793, autoreconf fails

Group
 
 

bug #52793: autoreconf fails

Submitter:  Yavor Doganov <yavor>
Submitted:  Wed 03 Jan 2018 12:11:55 PM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 07 Jan 2018 01:50:26 PM UTC, comment #1: 

I applied your patch. Thank you very much for it.

Fred Kiefer <FredKiefer>
Group Member
Wed 03 Jan 2018 12:11:55 PM UTC, original submission:  

This is similar to Bug #52779 but not identical, so I'm reporting it as a separate bug.


$ autoreconf -fi
configure.ac:275: error: possibly undefined macro: PKG_XFT
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:455: error: possibly undefined macro: PKG_CAIRO
configure.ac:457: error: possibly undefined macro: PKG_CAIRO_FT
configure.ac:459: error: possibly undefined macro: PKG_CAIRO_XLIB
configure.ac:463: error: possibly undefined macro: PKG_CAIRO_GLITZ
configure.ac:465: error: possibly undefined macro: PKG_FONTCONFIG
autoreconf: /usr/bin/autoconf failed with exit status: 1
$ cp ../libs-gui/config/pkg.m4 .
$ rm aclocal.m4
$ autoreconf -fi
configure.ac:275: error: possibly undefined macro: PKG_XFT
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:455: error: possibly undefined macro: PKG_CAIRO
configure.ac:457: error: possibly undefined macro: PKG_CAIRO_FT
configure.ac:459: error: possibly undefined macro: PKG_CAIRO_XLIB
configure.ac:463: error: possibly undefined macro: PKG_CAIRO_GLITZ
configure.ac:465: error: possibly undefined macro: PKG_FONTCONFIG
autoreconf: /usr/bin/autoconf failed with exit status: 1


This is because newer pkg.m4 macros now use m4_pattern_forbid to reserve their own namespace.  Proposed patch attached.

P.S. PKG_PROG_PKG_CONFIG is AC_REQUIREd by PKG_CHECK_MODULES and generally shouldn't be necessary to be called explicitly.  However, the first call to PKG_CHECK_MODULES (for xext) is conditional and that's why the macro is not expanded and later it fails to detect cairo.  If you use AS_IF instead of plain "if" autoconf would be able to "see" that and the AC_REQUIRE machinery would work.  So, either an explicit call to PKG_PROG_PKG_CONFIG is neeeded, or rewrite the if statement as

AS_IF([test "$HAVE_LIBXext" = no], [PKG_CHECK_MODULES([XEXT], [xext])])

Yavor Doganov <yavor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-11 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2018-01-07 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2018-01-03 yavor Attached File- Added 0001-Fix-autoreconf-failure.patch, #42799

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code