bugGNUstep - Bugs: bug #52779, autoreconf generates broken...

Group
 
 

bug #52779: autoreconf generates broken configure

Submitter:  Yavor Doganov <yavor>
Submitted:  Mon 01 Jan 2018 08:04:22 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 01 Jan 2018 09:41:28 PM UTC, comment #2: 

As there was a newer version of pkg.m4 on my system I use this and I also regenerated the configure file.

Thank you for your patch.
Fred

Fred Kiefer <FredKiefer>
Group Member
Mon 01 Jan 2018 08:07:36 PM UTC, comment #1: 

Typo in submission:

/usr/share/acloclal.m4 -> /usr/share/aclocal/pkg.m4

Yavor Doganov <yavor>
Mon 01 Jan 2018 08:04:22 PM UTC, original submission:  

To reproduce, run

$ autoreconf
$ ./configure

Observe the error messages; all of them are due to the completely broken configure script.  (Naturally, compilation also fails.)  This happens because autoreconf invokes aclocal, which in turn detects that pkg.m4 from ACDIR (/usr/share/aclocal in my case) is newer than config/pkg.m4, so it creates aclocal.m4, copying the macro definition from /usr/share/aclocal.m4.  Autoconf then makes a mess since config/pkg.m4 is included via the m4 builtin macro and on top of that is underquoted.

Attached is a non-intrusive patch which simply updates config/pkg.m4.  A better approach which would be to use the standard/recommended way of dealing with additional macros:

AC_CONFIG_MACRO_DIR([config])

That way, when you regenerate configure with `autoreconf -i', the macros under config/ will be updated if a newer version of the .m4 file is available by the package that is providing it (pkg-config for pkg.m4 and autoconf-archive for icu.m4).

I suspect that the current approach was preferred in order to avoid aclocal (as it is part of GNU Automake).  I think it is reasonable to expect that any user or developer who has to modify configure.ac has automake installed.  Also, autoreconf is the recommended way of (re)generating the GNU build system and most users are accustomed to it.

Yavor Doganov <yavor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-11 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2018-01-01 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2018-01-01 yavor Attached File- Added 0001-Update-pkg.m4-to-serial-11.patch, #42783

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code