bugGNU Octave - Bugs: bug #44053, pkg install general fails

 
 

bug #44053: pkg install general fails

Submitter:  Avinoam Kalma <avinoam>
Submitted:  Tue 20 Jan 2015 02:54:09 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Avinoam Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 22 Jan 2015 02:21:19 AM UTC, comment #20: 
John Donoghue <lostbard>
Group Member
Wed 21 Jan 2015 08:53:21 PM UTC, comment #19: 

looks good

John Donoghue <lostbard>
Group Member
Wed 21 Jan 2015 08:38:14 PM UTC, comment #18: 

Is this a suitable changeset?


(file #32895)

Avinoam Kalma <avinoam>
Group Member
Wed 21 Jan 2015 11:25:20 AM UTC, comment #17: 

Thanks - Can you make it a hg changeset so it has the user info, list of changes etc in it as per [1] and I will push it later today.




[1] https://www.gnu.org/software/octave/doc/interpreter/General-Guidelines.html#General-Guidelines

John Donoghue <lostbard>
Group Member
Wed 21 Jan 2015 10:22:02 AM UTC, comment #16: 

a patch enclsoed.



(file #32882)

Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 11:28:40 PM UTC, comment #15: 

could also set OMP_NUM_THREADS to 1, however I guess that then will effect more than just make.

John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 10:17:10 PM UTC, comment #14: 

What do you think about this fix:


    if (ispc)
      jobs = 1;
    else
      jobs = nproc ("overridable");
    endif

    if (exist (fullfile (src, "Makefile"), "file"))
      [status, output] = shell (sprintf ("%s make --jobs %i --directory '%s'",
                                         scenv, jobs, src),
                                verbose);


Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 10:05:59 PM UTC, comment #13: 

Was just about to say that - make in mingw doesn't seem very reliable with anything other than -j 1.

John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 09:53:04 PM UTC, comment #12: 

the "--jobs 2" is the problematic command. Removing it,
the pkg install succeed.


Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 09:46:46 PM UTC, comment #11: 


Using

[status, output] = shell ([scenv "make -C '" src "'"], verbose);


the command sent to shell is:

cmd = MKOCTFILE='C:\Octave\Octave-4.1.0+\bin\mkoctfile-4.1.0+.exe' OCTAVE_CO
NFIG='C:\Octave\Octave-4.1.0+\bin\octave-config-4.1.0+.exe' OCTAVE='C:\Octav
e\Octave-4.1.0+\bin\octave-4.1.0+.exe' INSTALLDIR='C:\Octave\Octave-4.1.0+\s
hare\octave\packages\general-1.3.4' make -C 'C:\Users\avinoam\AppData\Local\
Temp\oct-2R3gDp\general\src'


In version 4.1.0, the command is:

cmd = MKOCTFILE='C:\Octave\Octave-4.1.0+\bin\mkoctfile-4.1.0+.exe' OCTAVE_CO
NFIG='C:\Octave\Octave-4.1.0+\bin\octave-config-4.1.0+.exe' OCTAVE='C:\Octav
e\Octave-4.1.0+\bin\octave-4.1.0+.exe' INSTALLDIR='C:\Octave\Octave-4.1.0+\s
hare\octave\packages\general-1.3.4'  make --jobs 2 --directory 'C:\Users\avi
noam\AppData\Local\Temp\oct-3GcETJ\general\src'


Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 09:23:23 PM UTC, comment #10: 

And what is the actual command being sent to shell?

Also - try without the verbose command - I had an issue last week where it wouldn't install io correctly. A change was made for it, however I cant remember now if I got around to retesting it on my computer.

John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 08:19:43 PM UTC, comment #9: 

checking the difference between ver 3.8.2.
the failure is caused by changing the line

      [status, output] = shell ([scenv "make -C '" src "'"], verbose);


to

      [status, output] = shell (sprintf ("%s make --jobs %i --directory '%s'",
                                         scenv, nproc ("overridable"), src),
                                verbose);


Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 07:40:41 PM UTC, comment #8: 

If I take configure_make.m from ver 3.8.2 and put it in
C:\Octave\Octave-4.1.0+\share\octave\4.1.0+\m\pkg\private instead of current file, the pkg install succeed

Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 06:25:24 PM UTC, comment #7: 

/home/avinoam/mxe-octave/usr/i686-w64-mingw32/lib -L/home/avinoam/mxe-octave/usr/i686-w64-mingw32/lib

John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 06:22:31 PM UTC, comment #6: 

I can't reproduce it.
The last week I've been making daily mxe builds (combined 3.9.0+/4.1.0+); trying in 4.1.0+, general-1.3.4 installs fine, both from forge and from the ./src subdir.

BTW I run build_packages in 3.9.0+ as due to deprecated stuff a number of them won´t install in 4.1.0+ anymore.

What´s up with the "libs from Ubuntu build" ? I can´t follow what you mean there.

Philip Nienhuis <philipnienhuis>
Group Member
Tue 20 Jan 2015 05:09:21 PM UTC, comment #5: 

I just noticed on mine that it is pulling an old version of mkoctfile from my mxe build, which may be why mine is working.

I'll do a rebuild

John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 04:39:13 PM UTC, comment #4: 


I use for the mxe octave

./configure --enable-octave=default


Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 04:10:59 PM UTC, comment #3: 

Should work - probably doesn't need the PATH= as the Makefile should do that.

What configure options did you give to mxe-octave?

last build I did was a few days ago - I will try a later rebuild on mine.


John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 04:02:56 PM UTC, comment #2: 

4.1.0 - changeset 19590:6d75f1683ce8
Here is the script I use to build octave

cd ~/octave
hg  pull
hg  update
cd ~/octave-build
make
make dist
cp octave-4.1.0+.tar.gz ~/mxe-octave/pkg
cd ~/mxe-octave
hg  pull
hg  update
PATH=`pwd`/usr/bin:$PATH
touch src/default-octave.mk
make nsis-installer


Is it correct?

Avinoam Kalma <avinoam>
Group Member
Tue 20 Jan 2015 03:42:22 PM UTC, comment #1: 

I get the build directories as well, however it still compiles and installs fine on my Win7 machine.

What opts were used in mxe-octave, and what was the hg id of 4.1.0 you are using?


John Donoghue <lostbard>
Group Member
Tue 20 Jan 2015 02:54:09 PM UTC, original submission:  


pkg install general -verbose
fails in mxe-octave (it works well in Ubuntu)


>> pkg -verbose install general -forge
mkdir (C:\Users\avinoam\AppData\Local\Temp\oct-OHaNLg)
untar (C:\Users\avinoam\general-1.3.4.tar.gz, C:\Users\avinoam\AppData\Local
\Temp\oct-OHaNLg)
make: Entering directory `/tmp/oct-OHaNLg/general/src'
C:/Octave/Octave-4.1.0+/bin/mkoctfile-4.1.0+.exe --verbose SHA1.cc
C:/Octave/Octave-4.1.0+/bin/mkoctfile-4.1.0+.exe --verbose mark_for_deletion
.cc
g++ -c -I/home/avinoam/mxe-octave/usr/i686-w64-mingw32/include  -IC:\Octave\
Octave-4.1.0+\include\octave-4.1.0+\octave\.. -IC:\Octave\Octave-4.1.0+\incl
ude\octave-4.1.0+\octave -IC:\Octave\Octave-4.1.0+\include -mieee-fp -g -O2
-pthread    SHA1.cc -o SHA1.o
g++ -c -I/home/avinoam/mxe-octave/usr/i686-w64-mingw32/include  -IC:\Octave\
Octave-4.1.0+\include\octave-4.1.0+\octave\.. -IC:\Octave\Octave-4.1.0+\incl
ude\octave-4.1.0+\octave -IC:\Octave\Octave-4.1.0+\include -mieee-fp -g -O2
-pthread    mark_for_deletion.cc -o mark_for_deletion.o
g++ -shared -Wl,--export-all-symbols -Wl,--enable-auto-import -Wl,--enable-r
untime-pseudo-reloc  -o mark_for_deletion.oct  mark_for_deletion.o   -LC:\Oc
tave\Octave-4.1.0+\lib\octave\4.1.0+ -LC:\Octave\Octave-4.1.0+\lib -loctinte
rp -loctave -Wl,-rpath-link,/home/avinoam/mxe-octave/usr/i686-w64-mingw32/li
b -L/home/avinoam/mxe-octave/usr/i686-w64-mingw32/lib -Wl,--export-all-symbo
ls
g++ -shared -Wl,--export-all-symbols -Wl,--enable-auto-import -Wl,--enable-r
untime-pseudo-reloc  -o SHA1.oct  SHA1.o   -LC:\Octave\Octave-4.1.0+\lib\oct
ave\4.1.0+ -LC:\Octave\Octave-4.1.0+\lib -loctinterp -loctave -Wl,-rpath-lin
k,/home/avinoam/mxe-octave/usr/i686-w64-mingw32/lib -L/home/avinoam/mxe-octa
ve/usr/i686-w64-mingw32/lib -Wl,--export-all-symbols

the installation remains with the last command, withoout
failure message. Note that the libs with mxe-octave are from the
Ubuntu build and are not relevant for windows build

Avinoam Kalma <avinoam>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32895:  bug44053.patch added by avinoam (960B - application/octet-stream)
file #32882:  bug44053.cs added by avinoam (751B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by avinoam (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-01-24 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2015-01-22 lostbard StatusNone Ready For Test
    2015-01-21 avinoam Attached File- Added bug44053.patch, #32895
    2015-01-21 avinoam Attached File- Added bug44053.cs, #32882

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code