bugGNU Octave - Bugs: bug #36981, Add button(s) to close...

 
 

bug #36981: Add button(s) to close settings-dialog.ui

Submitter:  Mike Miller <mtmiller>
Submitted:  Sat 28 Jul 2012 02:22:32 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 02 Sep 2012 10:06:04 PM UTC, comment #4: 

Applied with some changes to the log message.

http://hg.savannah.gnu.org/hgweb/octave/rev/c5d09a57ceb2

Thanks.

Mike Miller <mtmiller>
Group Member
Sun 02 Sep 2012 08:46:40 PM UTC, comment #3: 

Version 2 of patch without corrections of non-related errors in the settings dialog.

(file #26464)

Torsten Lilge <ttl>
Group Member
Sun 02 Sep 2012 07:51:46 PM UTC, comment #2: 

Yes, works for me. However, there are some unrelated changes to other widgets in settings-dialog.ui that would be better done in a separate changeset. Can you clean those out and resubmit?

Mike Miller <mtmiller>
Group Member
Sun 02 Sep 2012 06:36:15 PM UTC, comment #1: 

The attached patch provides a "Cancel" / "OK" button pair.


(file #26461)

Torsten Lilge <ttl>
Group Member
Sat 28 Jul 2012 02:22:32 PM UTC, original submission:  

Please consider adding either a "Close" button or a pair of "Cancel" "OK" buttons to settings-dialog.ui.

In the default Gnome3 environment, dialog windows do not get any decoration so there is no graphical way to close the current settings-dialog. I can hit the Escape key on my keyboard, but that's it. In general, you can't rely on the window manager to provide the close button for you.

A single "Close" button would be enough for me, but some people may prefer a "Cancel" option as well, that looks like it would be easy logic for.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26464:  buttons_settings_diag_v2.diff added by ttl (3KiB - text/x-patch - patch providing buttons without non-related changes in dialog)
file #26461:  buttons_settings_diag.diff added by ttl (4KiB - text/x-patch - patch providing "Cancel" and "OK" buttons)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-02 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed
    2012-09-02 ttl Attached File- Added buttons_settings_diag_v2.diff, #26464
    2012-09-02 ttl Attached File- Added buttons_settings_diag.diff, #26461

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code