bugGNU Octave - Bugs: bug #39345, symbolic package: Fix test in...

 
 

bug #39345: symbolic package: Fix test in sym2poly

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Wed 26 Jun 2013 04:06:00 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Wont Fix Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Sun 22 Feb 2015 06:20:02 AM UTC, comment #3: 

The brand new symbolic package does not have a failing test in sym2poly:


>> test @sym/sym2poly
PASSES 11 out of 11 tests


Closing report as won't fix since the old symbolic package has been replaced.

Mike Miller <mtmiller>
Group Member
Wed 26 Jun 2013 08:12:47 PM UTC, comment #2: 

You are right, the problem is not due to the fact that the arguments are cell arrays, but because the elements are symbolic expressions.  For instance, this fails:


assert (sym ("x"), sym ("x"))


Anyway, the patch is still necessary.  However, if you decide to apply it, please change the description.

Rafael Laboissière <rlaboiss>
Wed 26 Jun 2013 05:52:44 PM UTC, comment #1: 

I don't have the symbolic package to test this but does assert really fails on cell arrays? The following works fine on my system (dev version and 3.6.2).


assert ({7 8 9}, {7 8 9})


Carnë Draug <carandraug>
Group Member
Wed 26 Jun 2013 04:06:00 PM UTC, original submission:  

This bug was introduced by me in cset 46a454.  The assert function does not support cells as arguments to be compared (observed and expected). This can be fixed by passing the string representation of both values, as in the patched attached to this bug report.

Rafael Laboissière <rlaboiss>

 

Attached Files

Attached Files
file #28427:  fix-test-in-sym2poly.diff added by rlaboiss (875B - text/x-patch - Patch for inst/sym2poly.m)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

    History

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-22 mtmiller StatusPatch Submitted Wont Fix
        Open/ClosedOpen Closed
    2014-01-20 mtmiller StatusNone Patch Submitted
    2013-06-26 carandraug SummaryFix test in sym2poly symbolic package: Fix test in sym2poly
    2013-06-26 rlaboiss Attached File- Added fix-test-in-sym2poly.diff, #28427

    Back to the top

    Powered by Savane 3.16-1eaf.
    Corresponding source code