bugGNU GRUB - Bugs: bug #41582, Double free in grub-probe when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #41582: Double free in grub-probe when using LVM

Submitter:  Vladimir Smirnov <civil>
Submitted:  Thu 13 Feb 2014 07:33:42 PM UTC
Votes: 13
 
Category:  User Interface Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  Fixed Privacy:  Public
Assigned to:  None Originator Name:  Vladimir Smirnov
Open/Closed:  Closed Release:  Git master
Release:  Reproducibility:  Every Time
Planned Release:  None

Sat 14 Feb 2015 04:12:29 PM UTC, comment #5: 

I now pushed fc535b32b9fe0cd84213724ffba43b98e2da6ab4 with different fix that makes sure each string is allocated independently in grub_diskfilter_make_raid. This avoids need to special case it. It also closes memory leak you mention and also in grub_diskfilter_make_raid failure branch.

Please reopen if you still see it.

Andrei Borzenkov <arvidjaar>
Group Member
Thu 03 Jul 2014 02:53:15 PM UTC, comment #4: 

AFAIK, we've talked about that via IRC. Yes, this patch also fix the problem.

Also, please have a look on memory leaks I've attached. It's not critical, just not good.

Vladimir Smirnov <civil>
Sun 22 Jun 2014 01:57:46 AM UTC, comment #3: 

vg->name is the same as lv->name for MDRAID. Please try attached patch.

(file #31590)

Vladimir Serbinenko <phcoder>
Group administrator
Thu 19 Jun 2014 05:56:48 PM UTC, comment #2: 

I have used the patches submitted by Vladimir and it correctly addresses the problem.   
Paul

Paul Lupa <plupa>
Thu 13 Feb 2014 07:45:57 PM UTC, comment #1: 

I've forgot to mention some details (may be important):
1) It's rather strange disk layout:
GPT (4x4TB HDD):
1) 128MB Free space, bios_boot flag
2) MDADM RAID10, /boot, ext3
3) MDADM RAID10, LVM vg0 (for /, /home, etc)
4) MDADM RAID10, LVM vg1 (data partitions).

It may be important.

Vladimir Smirnov <civil>
Thu 13 Feb 2014 07:33:42 PM UTC, original submission:  

I've upgraded grub from 1.99 to 2.0 (also tried 2.02 beta2 and git master), and I've found a bug in grub-probe, when running it says:

* glibc detected * ./grub-probe: double free or corruption (fasttop): 0x0000000000838760 *
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x7f0487d76b96]
./grub-probe[0x4a4ec6]
./grub-probe[0x4b651e]
./grub-probe[0x4b66a8]
./grub-probe[0x4b6693]
./grub-probe[0x4a444d]
./grub-probe[0x4a2bde]
./grub-probe[0x4a2d1a]
./grub-probe[0x4a2dc7]
./grub-probe[0x49bf3b]
./grub-probe[0x49c461]
./grub-probe[0x49bfa7]
./grub-probe[0x49bfcd]
./grub-probe[0x4035f9]
./grub-probe[0x404d25]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x7f0487d1976d]
./grub-probe[0x402c99]
======= Memory map: ========
00400000-004fd000 r-xp 00000000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fd000-006fe000 r--p 000fd000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fe000-00706000 rw-p 000fe000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
00706000-00714000 rw-p 00000000 00:00 0
00833000-008ca000 rw-p 00000000 00:00 0                                  [heap]
7f0486dc0000-7f0486dd5000 r-xp 00000000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486dd5000-7f0486fd4000 ---p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd4000-7f0486fd5000 r--p 00014000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd5000-7f0486fd6000 rw-p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd8000-7f0487292000 r--p 00000000 fc:01 4194946                    /usr/lib/locale/locale-archive
7f0487298000-7f04872b0000 r-xp 00000000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04872b0000-7f04874af000 ---p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874af000-7f04874b0000 r--p 00017000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b0000-7f04874b1000 rw-p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b1000-7f04874b5000 rw-p 00000000 00:00 0
7f04874b8000-7f04874bf000 r-xp 00000000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04874bf000-7f04876be000 ---p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876be000-7f04876bf000 r--p 00006000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876bf000-7f04876c0000 rw-p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876c0000-7f04876c2000 r-xp 00000000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04876c2000-7f04878c2000 ---p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c2000-7f04878c3000 r--p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c3000-7f04878c4000 rw-p 00003000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c8000-7f04878d4000 r-xp 00000000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f04878d4000-7f0487ad3000 ---p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad3000-7f0487ad4000 r--p 0000b000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad4000-7f0487ad5000 rw-p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad8000-7f0487af5000 r-xp 00000000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487af5000-7f0487cf4000 ---p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf4000-7f0487cf5000 r--p 0001c000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf5000-7f0487cf6000 rw-p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf6000-7f0487cf7000 rw-p 00000000 00:00 0
7f0487cf8000-7f0487ead000 r-xp 00000000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f0487ead000-7f04880ad000 ---p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880ad000-7f04880b1000 r--p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b1000-7f04880b3000 rw-p 001b9000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b3000-7f04880b8000 rw-p 00000000 00:00 0
7f04880b8000-7f04880d8000 r-xp 00000000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04880d8000-7f04882d8000 ---p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d8000-7f04882d9000 r--p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d9000-7f04882db000 rw-p 00021000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882e0000-7f0488302000 r-xp 00000000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f04884f5000-7f04884f8000 rw-p 00000000 00:00 0
7f0488500000-7f0488501000 rw-p 00000000 00:00 0
7f0488501000-7f0488502000 rw-p 00000000 00:00 0
7f0488502000-7f0488503000 r--p 00022000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488503000-7f0488505000 rw-p 00023000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488505000-7f0488508000 rw-p 00000000 00:00 0
7fff794f0000-7fff79517000 rw-p 00000000 00:00 0                          [stack]
7fff795e0000-7fff795e2000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
* glibc detected * ./grub-probe: double free or corruption (fasttop): 0x0000000000838760 *
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x7f0487d76b96]
./grub-probe[0x4a4ec6]
./grub-probe[0x4b651e]
./grub-probe[0x4b66a8]
./grub-probe[0x4b6693]
./grub-probe[0x4a444d]
./grub-probe[0x4a2bde]
./grub-probe[0x4a2d1a]
./grub-probe[0x4a2dc7]
./grub-probe[0x49bf3b]
./grub-probe[0x49c461]
./grub-probe[0x49c013]
./grub-probe[0x4035f9]
./grub-probe[0x404d25]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x7f0487d1976d]
./grub-probe[0x402c99]
======= Memory map: ========
00400000-004fd000 r-xp 00000000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fd000-006fe000 r--p 000fd000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fe000-00706000 rw-p 000fe000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
00706000-00714000 rw-p 00000000 00:00 0
00833000-008ca000 rw-p 00000000 00:00 0                                  [heap]
7f0486dc0000-7f0486dd5000 r-xp 00000000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486dd5000-7f0486fd4000 ---p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd4000-7f0486fd5000 r--p 00014000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd5000-7f0486fd6000 rw-p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd8000-7f0487292000 r--p 00000000 fc:01 4194946                    /usr/lib/locale/locale-archive
7f0487298000-7f04872b0000 r-xp 00000000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04872b0000-7f04874af000 ---p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874af000-7f04874b0000 r--p 00017000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b0000-7f04874b1000 rw-p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b1000-7f04874b5000 rw-p 00000000 00:00 0
7f04874b8000-7f04874bf000 r-xp 00000000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04874bf000-7f04876be000 ---p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876be000-7f04876bf000 r--p 00006000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876bf000-7f04876c0000 rw-p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876c0000-7f04876c2000 r-xp 00000000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04876c2000-7f04878c2000 ---p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c2000-7f04878c3000 r--p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c3000-7f04878c4000 rw-p 00003000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c8000-7f04878d4000 r-xp 00000000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f04878d4000-7f0487ad3000 ---p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad3000-7f0487ad4000 r--p 0000b000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad4000-7f0487ad5000 rw-p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad8000-7f0487af5000 r-xp 00000000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487af5000-7f0487cf4000 ---p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf4000-7f0487cf5000 r--p 0001c000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf5000-7f0487cf6000 rw-p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf6000-7f0487cf7000 rw-p 00000000 00:00 0
7f0487cf8000-7f0487ead000 r-xp 00000000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f0487ead000-7f04880ad000 ---p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880ad000-7f04880b1000 r--p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b1000-7f04880b3000 rw-p 001b9000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b3000-7f04880b8000 rw-p 00000000 00:00 0
7f04880b8000-7f04880d8000 r-xp 00000000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04880d8000-7f04882d8000 ---p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d8000-7f04882d9000 r--p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d9000-7f04882db000 rw-p 00021000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882e0000-7f0488302000 r-xp 00000000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f04884f5000-7f04884f8000 rw-p 00000000 00:00 0
7f0488500000-7f0488501000 rw-p 00000000 00:00 0
7f0488501000-7f0488502000 rw-p 00000000 00:00 0
7f0488502000-7f0488503000 r--p 00022000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488503000-7f0488505000 rw-p 00023000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488505000-7f0488508000 rw-p 00000000 00:00 0
7fff794f0000-7fff79517000 rw-p 00000000 00:00 0                          [stack]
7fff795e0000-7fff795e2000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
ext2
* glibc detected * ./grub-probe: double free or corruption (fasttop): 0x0000000000838760 *
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x7f0487d76b96]
./grub-probe[0x4a4ec6]
./grub-probe[0x4b651e]
./grub-probe[0x4b66a8]
./grub-probe[0x4b6693]
./grub-probe[0x408f76]
./grub-probe[0x404d91]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x7f0487d1976d]
./grub-probe[0x402c99]
======= Memory map: ========
00400000-004fd000 r-xp 00000000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fd000-006fe000 r--p 000fd000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
006fe000-00706000 rw-p 000fe000 fc:01 1708269                            /home/civil/grub/grub-2.02~beta2/grub-probe
00706000-00714000 rw-p 00000000 00:00 0
00833000-009d2000 rw-p 00000000 00:00 0                                  [heap]
7f0486dc0000-7f0486dd5000 r-xp 00000000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486dd5000-7f0486fd4000 ---p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd4000-7f0486fd5000 r--p 00014000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd5000-7f0486fd6000 rw-p 00015000 fc:01 5243270                    /lib/x86_64-linux-gnu/libgcc_s.so.1
7f0486fd8000-7f0487292000 r--p 00000000 fc:01 4194946                    /usr/lib/locale/locale-archive
7f0487298000-7f04872b0000 r-xp 00000000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04872b0000-7f04874af000 ---p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874af000-7f04874b0000 r--p 00017000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b0000-7f04874b1000 rw-p 00018000 fc:01 5246750                    /lib/x86_64-linux-gnu/libpthread-2.15.so
7f04874b1000-7f04874b5000 rw-p 00000000 00:00 0
7f04874b8000-7f04874bf000 r-xp 00000000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04874bf000-7f04876be000 ---p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876be000-7f04876bf000 r--p 00006000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876bf000-7f04876c0000 rw-p 00007000 fc:01 5246748                    /lib/x86_64-linux-gnu/librt-2.15.so
7f04876c0000-7f04876c2000 r-xp 00000000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04876c2000-7f04878c2000 ---p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c2000-7f04878c3000 r--p 00002000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c3000-7f04878c4000 rw-p 00003000 fc:01 5246756                    /lib/x86_64-linux-gnu/libdl-2.15.so
7f04878c8000-7f04878d4000 r-xp 00000000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f04878d4000-7f0487ad3000 ---p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad3000-7f0487ad4000 r--p 0000b000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad4000-7f0487ad5000 rw-p 0000c000 fc:01 5243268                    /lib/x86_64-linux-gnu/libudev.so.0.13.0
7f0487ad8000-7f0487af5000 r-xp 00000000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487af5000-7f0487cf4000 ---p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf4000-7f0487cf5000 r--p 0001c000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf5000-7f0487cf6000 rw-p 0001d000 fc:01 5243247                    /lib/x86_64-linux-gnu/libselinux.so.1
7f0487cf6000-7f0487cf7000 rw-p 00000000 00:00 0
7f0487cf8000-7f0487ead000 r-xp 00000000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f0487ead000-7f04880ad000 ---p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880ad000-7f04880b1000 r--p 001b5000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b1000-7f04880b3000 rw-p 001b9000 fc:01 5243207                    /lib/x86_64-linux-gnu/libc-2.15.so
7f04880b3000-7f04880b8000 rw-p 00000000 00:00 0
7f04880b8000-7f04880d8000 r-xp 00000000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04880d8000-7f04882d8000 ---p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d8000-7f04882d9000 r--p 00020000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882d9000-7f04882db000 rw-p 00021000 fc:01 5243041                    /lib/libdevmapper.so.1.02.1
7f04882e0000-7f0488302000 r-xp 00000000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f04884f5000-7f04884f8000 rw-p 00000000 00:00 0
7f04884ff000-7f0488502000 rw-p 00000000 00:00 0
7f0488502000-7f0488503000 r--p 00022000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488503000-7f0488505000 rw-p 00023000 fc:01 5246753                    /lib/x86_64-linux-gnu/ld-2.15.so
7f0488505000-7f0488508000 rw-p 00000000 00:00 0
7fff794f0000-7fff79517000 rw-p 00000000 00:00 0                          [stack]
7fff795e0000-7fff795e2000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
Aborted


So I've started digging. With some help, it was narrowed down to
grub-core/disk/diskfilter.c:886 where first free occured.

It seems that for some reasons, lv->fullname == lv->name == vg->name, but there lv->fullname is freed and replaced with new value (but lv->name and vg->name is not).

I've created a simple patch for that. Though, I'm a bit in doubt about it's correctness, because I can't understand why vg->name == lv->fullname.

While digging, I've also find small memory leak (lv->idname is allocated, but never freed), and also fixed it.

I hope it'll help somebody.

Vladimir Smirnov <civil>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #31590:  1.diff added by phcoder (554B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arvidjaar (Posted a comment)
  • -email is unavailable- added by ppawlow (Voted in favor of this item)
  • -email is unavailable- added by phcoder (Updated the item)
  • -email is unavailable- added by plupa (Posted a comment)
  • -email is unavailable- added by plupa (Voted in favor of this item)
  • -email is unavailable- added by civil (Submitted the item)
  •  

    There are 13 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-14 arvidjaar StatusNone Fixed
        Open/ClosedOpen Closed
    2014-10-05 ppawlow Carbon-Copy- Added ppawlow
    2014-06-22 phcoder Attached File- Added 1.diff, #31590
    2014-06-19 plupa Carbon-Copy- Added plupa
    2014-02-13 civil Attached File- Added 0001-Fix-double-free-when-using-LVM.patch, #30542
        Attached File- Added 0002-Fix-small-memory-leak.patch, #30543

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code