bugGNUstep - Bugs: bug #38024, NSBitmapImageRep+GIF.m uses...

Group
 
 

bug #38024: NSBitmapImageRep+GIF.m uses undefined function QuantizeBuffer

Submitter:  Wolfgang Lux <wlux>
Submitted:  Sat 05 Jan 2013 03:58:47 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 16 Jan 2013 08:14:44 PM UTC, comment #4: 

Fixed by Wolfgang himself, but he may not have the right to close this.

Fred Kiefer <FredKiefer>
Group Member
Sun 13 Jan 2013 01:50:05 PM UTC, comment #3: 

I added a fix to return nil from _GIFRepresentationWithProperties:errorMessage: when QuantizeBuffer is not available.

Wolfgang Lux <wlux>
Tue 08 Jan 2013 08:07:10 AM UTC, comment #2: 

Good to know that the function will come back.
I think disabling gif support for giflib 4.2 seems a bit too harsh. A quick test with the ImageViewer application shows that I can still view gif images. The only method that uses QuantizeBuffer is _GIFRepresentationWithProperties:errorMessage:, which in turn is used only by NSBitmapRep -representationUsingType:properties:. I guess it would suffice to disable support for creating new image representations with type .gif (which is considered experimental anyway, according to an NSLog call).
I'll try to have a look at this next weekend.

Wolfgang Lux <wlux>
Sun 06 Jan 2013 11:37:28 PM UTC, comment #1: 

While googling for the function I found the following entry:

http://sourceforge.net/p/giflib/feature-requests/4/

Looks like the function is coming back to giflib, we just need a solution for the inbetween versions. Best to add a check for that function in configure.ac. My OpenSuse system uses libungif 4.1.6, it would be better if you could write the check and disable GIF support, when that function is missing.


Fred Kiefer <FredKiefer>
Group Member
Sat 05 Jan 2013 03:58:47 PM UTC, original submission:  

After updating gnustep-gui, I noticed the following message:

NSBitmapImageRep+GIF.m: In function '-[NSBitmapImageRep(GIFReading) _GIFRepresentationWithProperties:errorMessage:]':
NSBitmapImageRep+GIF.m:474:3: warning: implicit declaration of function 'QuantizeBuffer' [-Wimplicit-function-declaration]

It seems like this function was defined by giflib (and maybe libungif?), but the function  has been removed from giflib in version 4.2.

Wolfgang Lux <wlux>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rmottola (Updated the item)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by wlux (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-01-09 rmottola Open/ClosedIn Test Closed
    2013-01-16 FredKiefer StatusNone Fixed
        Open/ClosedOpen In Test

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code