Add a New Comment (Rich Markup)
( Jump to the original submission )
I fixed this by setting the new source and target options to 1.6. I also changed JNI_VERSION_1_2 to JNI_VERSION_1_6 thanks to a suggestion by Ernst on the mailing list. https://hg.savannah.gnu.org/hgweb/octave/rev/20c83f619102 I also dropped octave.jar from the source distribution https://hg.savannah.gnu.org/hgweb/octave/rev/712736d43124
I'm actually rethinking keeping the options, and maybe changing them to 1.6 for now. But dropping octave.jar is still valid. I just checked my mxe-octave build logs and it also uses the build host JDK to recompile the Java sources and create octave.jar. If I build Octave using Java 8 without specifying these options, then Octave can only use Java 8 or newer. This may be very important, especially for the Windows distribution, and maybe for other OS if we ever address bug #40111. So I think we do need to keep specifying a minimum to make sure the bytecode is backwards compatible.
@Mike: I saw your comment about Java on the Maintainer's list. It makes sense to me to drop distribution of the binary octave.jar and the other changes as well.
I saw this test failure as well, but since Java 9 is prerelease at this point, I don't think it's worth addressing until we know what the actual version number will look like once an actual release occurs.
With some risk of hijacking the bug report. I build octave with java-9 on Fedora and now some off the (java) tests are failing:
## Check for valid first two Java version numbers jver = strsplit (javaMethod ("getProperty", "java.lang.System", "java.version"), "."); assert (isfinite (str2double (jver{1})) && isfinite (str2double (jver{2}))); !!!!! test failed jver(2): out of bound 1 ... jver = strsplit (javaMethod ("getProperty", "java.lang.System", "java.version"), ".") jver = { [1,1] = 9 }
So if we to allow java-9 as well as older version this check should be modified. Dmitri. --
I'm planning on pushing the attached change, pending feedback on the maintainers list (waiting a couple days to see if anyone cares). This will drop the source and target options and remove octave.jar from the source distribution. (file #41592)
I have updated to OpenJDK 9 on Debian, and building Octave now results in the following errors
error: Source option 1.3 is no longer supported. Use 1.6 or later. error: Target option 1.3 is no longer supported. Use 1.6 or later.
I think the options should simply be dropped at this point, I'll post on the maintainers list to ask for feedback on the slightly bigger issue.
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only project members can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 5 latest changes.
Copyright © 2023 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.12