bugGNU Octave - Bugs: bug #39177, signal package: fir1(8000,0.01)...

 
 

bug #39177: signal package: fir1(8000,0.01) does not work

Submitter:  None
Submitted:  Thu 06 Jun 2013 03:17:18 PM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  mtmiller
Originator Name:  MATT Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * other
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Thu 23 Jan 2014 06:26:38 AM UTC, comment #3: 

This bug has been fixed, the fix will be part of the next signal package release.

http://sf.net/p/octave/signal/ci/58aef1

Mike Miller <mtmiller>
Project Administrator
Thu 13 Jun 2013 08:42:04 PM UTC, comment #2: 

Doesn't look like fir1 has changed substantially between versions, but fir2 has. Here's a comparison between octave-signal_1.1.3 and 1.2.2 in Debian (1.2.0 is quite similar).

[~/Downloads/signal/inst]$ diff fir1.m /usr/share/octave/packages/signal-1.2.2/fir1.m
143,145c143,145
< %!assert(fir1(2, .5, 'low', @hanning, 'scale'), [0 1 0]');
< %!assert(fir1(2, .5, 'low', "hanning", 'scale'), [0 1 0]');
< %!assert(fir1(2, .5, 'low', hanning(3), 'scale'), [0 1 0]');
---

> %!assert(fir1(2, .5, 'low', @hanning, 'scale'), [0 1 0]);
> %!assert(fir1(2, .5, 'low', "hanning", 'scale'), [0 1 0]);
> %!assert(fir1(2, .5, 'low', hanning(3), 'scale'), [0 1 0]);


[~/Downloads/signal/inst]$ diff fir2.m /usr/share/octave/packages/signal-1.2.2/fir2.m | wc -l
89

Furthermore, simple substitution of the old fir2 into a bare directory executes without error. I haven't yet checked that the output is correct. Qualitative checks with my own code and with freqz both suggest that it may be.

[~/octavebug]$ ls
fir2.m
[~/octavebug]$ octave
GNU Octave, version 3.6.4
...
octave:1> size(fir1(10000,0.01))
ans =

   10001       1

octave:2>

Charlie Hagedorn <isl>
Thu 06 Jun 2013 06:57:46 PM UTC, comment #1: 

Confirmed, fails for any filter order higher than 1023 because of the way it calls fir2.

Mike Miller <mtmiller>
Project Administrator
Thu 06 Jun 2013 03:17:18 PM UTC, original submission:  

b = fir1(8000,0.01) returns error message, "error : fir2 : grid size must be greater than half the filter order. "

Using Octave UPM R8.1, the fir1() function in 'Signal' package

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Carbon-Copy List
  • -email is unavailable- added by isl (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-05 mtmiller Dependencies- bugs #44423 is dependent
    2014-01-23 mtmiller Open/ClosedOpen Closed
    2014-01-23 mtmiller StatusConfirmed Fixed
    2013-08-25 mtmiller Dependencies- bugs #39864 is dependent
    2013-06-06 mtmiller StatusNone Confirmed
        Assigned toNone mtmiller
        Release3.6.4 other
        Operating SystemMicrosoft Windows Any
        Summaryfir1(8000,0.01) does not work signal package: fir1(8000,0.01) does not work

    Back to the top


    Powered by Savane 3.9