bugGNU roff - Bugs: bug #64913, Makefile.am: variable...

 
 

bug #64913: Makefile.am: variable "HOST" is not created by "automake"

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Mon 20 Nov 2023 06:26:58 PM UTC
   
 
Category:  General Severity:  2 - Minor
Item Group:  Documentation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 08 Sep 2024 01:46:31 AM UTC, comment #10: 


commit b80263448481795a38ee7e1566dbebbb1fabd40c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Sep 4 16:38:49 2024 -0500

    Makefile.am: Revise and update comments.

    * Use contemporary quotation style.  Eschew `this'.  Use single quotes
      for Automake variable/macro names and command literals, and double
      quotes for variable/macro contents and for file names.
    * De-document some variable names.  We need not be exhaustive; the
      GNU Autoconf manual exists for a reason.
    * Stop naming several variables twice, once with the quotation marks and
      once without.
    * Annotate variables that can go away as part of Savannah #63827.
    * Be more frugal with vertical whitespace, except where helpful to
      separate paragraphs of exposition.
    * Recast language.

    Fixes <https://savannah.gnu.org/bugs/?64913>.  Thanks to Bjarni Ingi
    Gislason for the report.


G. Branden Robinson <gbranden>
Group administrator
Wed 04 Sep 2024 09:38:15 PM UTC, comment #9: 

I'm not taking the patch in comment #2, though.  Removing "[PATCH]" annotation.

G. Branden Robinson <gbranden>
Group administrator
Wed 04 Sep 2024 09:35:21 PM UTC, comment #8: 

Updating Category.

"Core" is just "groff, nroff, troff, libgroff".

"General" is "issues that cut broadly across the source tree".

"Makefile.am" coordinates construction of everything that gets built.  Hard to get broader than that.

G. Branden Robinson <gbranden>
Group administrator
Wed 04 Sep 2024 09:33:06 PM UTC, comment #7: 

Okay.  I've tidied up the comments in "Makefile.am" and you can expect that in my next push.

G. Branden Robinson <gbranden>
Group administrator
Wed 04 Sep 2024 11:16:19 AM UTC, comment #6: 

Updating status based on the presumption that comment #4 supplied the Needed Info.

Dave <barx>
Group Member
Tue 09 Jan 2024 09:12:28 PM UTC, comment #5: 

Changing the Item Group: while the affected file is part of the build system, the problem is only in comment lines, which serve to document, not to build.

Dave <barx>
Group Member
Sat 25 Nov 2023 11:49:48 PM UTC, comment #4: 

My reading of the problem is that the variable name in the comments is misspelled (or more specifically miscased).

The lines in question are in the section of the file headed:

# The variables that are listed in the following comments will be
# automatically set by automake in the generated Makefile.in

Some variables in these comments are all-caps and some are lowercase, presumably in line with the corresponding automake-generated variables.

Dave <barx>
Group Member
Sat 25 Nov 2023 11:53:44 AM UTC, comment #3: 

I still don't understand what problem is being addressed here.

The patch alters only comments.

G. Branden Robinson <gbranden>
Group administrator
Thu 23 Nov 2023 11:40:23 PM UTC, comment #2: 

From 960c22e6f75db890ce3ed5a00037c1f9712dff36 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@simnet.is>
Date: Thu, 23 Nov 2023 21:53:08 +0000
Subject: [PATCH]   The automake program defines a variable named 'host' with
 the canonical host specification and not a variable named 'HOST'.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@simnet.is>
---
 Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index e15a8ff0f..b61de154e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -35,8 +35,8 @@

 # top_builddir

-# HOST
-# `HOST' is the canonical host specification,
+# host
+# `host' is the canonical host specification,
 #    CPU_TYPE-MANUFACTURER-OPERATING_SYSTEM
 # or
 #    CPU_TYPE-MANUFACTURER-KERNEL-OPERATING_SYSTEM
--
2.42.0

The patch is also in the attachment

(file #55352)

Bjarni Ingi Gislason <bjarniig>
Wed 22 Nov 2023 06:42:09 AM UTC, comment #1: 


original submission:

> Subject: Makefile.am: variable "HOST" is not created by "automake"


Why does it need to be?

G. Branden Robinson <gbranden>
Group administrator
Mon 20 Nov 2023 06:26:58 PM UTC, original submission:  

Subject: Makefile.am: variable "HOST" is not created by "automake"

  But "host" ("host_triplet = @host@" and host = @host@ in
Makefile.in) is.

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by barx (Posted a comment)
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-09-08 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2024-09-04 gbranden Summary[PATCH] Makefile.am: variable &quot;HOST&quot; is not created by &quot;automake&quot; Makefile.am: variable "HOST" is not created by "automake"
    2024-09-04 gbranden CategoryCore General
    2024-09-04 gbranden StatusNone In Progress
        Assigned toNone gbranden
    2024-09-04 barx StatusNeed Info None
    2024-01-12 gbranden Severity3 - Normal 2 - Minor
    2024-01-09 barx Item GroupBuild/Installation Documentation
        SummaryMakefile.am: variable &quot;HOST&quot; is not created by &quot;automake&quot; [PATCH] Makefile.am: variable "HOST" is not created by "automake"
    2023-11-23 bjarniig Attached File- Added 0001-The-automake-program-defines-a-variable-named-host-w.txt, #55352
    2023-11-22 gbranden StatusNone Need Info

    Back to the top

    Powered by Savane 3.14-f13d.
    Corresponding source code