bugGNU roff - Bugs: bug #64209, [PATCH] [mm] ".LO SJ"...

 
 

bug #64209: [PATCH] [mm] ".LO SJ" doesn't put a blank line after a letter's subject

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Wed 17 May 2023 12:18:56 PM UTC
   
 
Category:  Macro package mm Severity:  2 - Minor
Item Group:  Rendering/Cosmetics Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2023 08:51:55 AM UTC, comment #3: 


commit adc1be2bcfbc76692eeac71b571e6c5926c63396
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed May 17 22:52:18 2023 -0500

    [mm]: Fix Savannah #64209.

    * contrib/mm/m.tmac (let@print-head): Unconditionally `sp`ace after
      setting the text produced by ".LO SJ", instead of only doing so if the
      letter type was not "simplified" (".LT SP").

    Fixes <https://savannah.gnu.org/bugs/?64209>.


G. Branden Robinson <gbranden>
Group administrator
Mon 22 May 2023 07:55:14 AM UTC, comment #2: 
G. Branden Robinson <gbranden>
Group administrator
Wed 17 May 2023 12:30:42 PM UTC, comment #1: 

The fix is simple.  (Famous last words.)


diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
index c679a7089..5d33d6f45 100644
--- a/contrib/mm/m.tmac
+++ b/contrib/mm/m.tmac
@@ -3635,13 +3635,13 @@ undefined
 .      ie '\\*[let*type]'SP' \{\
 .              sp 2
 .              misc@toupper "\\*[let*lo-SJ]"
-.              sp
 .      \}
 .      el \{\
 .              sp
 .              if '\\*[let*type]'SB' .ti +5m
 \\*[LetSJ] \f[\\*[@sdf_font]]\\*[let*lo-SJ]\fP
 .      \}
+.      sp
 .\}
 ..
 .\"-------------------


G. Branden Robinson <gbranden>
Group administrator
Wed 17 May 2023 12:18:56 PM UTC, original submission:  

There are some minor differences between how DWB 3.3 mm and groff mm format letters (see the `LT` macro), particularly when `LO` letter options are used.

1.  DWB mm puts two spaces after colons in the notations generated by `.LO RN`, `.LO AT`, and `.LO SJ`.  groff mm puts only one.  I don't see this as a problem.  groff's approach is more flexible, permitting the user to put in extra (non-breaking?) spaces themselves if they desire rather than negative horizontal motion escape sequences if they don't.

2. DWB mm puts two blank lines above the formal closing, where groff mm puts only one.  I don't think this is a problem either, for analogous reasons to the preceding item.

3. DWB puts a blank line after the subject and before the body of the letter (typically a paragraph macro).  groff mm doesn't--this is ugly.  Fix it.

(I checked Heirloom Doctools troff mm too.  It appears to be broken.)

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-10 gbranden StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2023-05-22 gbranden StatusIn Progress Ready for Merge
    2023-05-17 gbranden StatusNone In Progress
        Assigned toNone gbranden
        Summary[mm] &quot;.LO SJ&quot; doesn't put a blank line after a letter's subject [PATCH] [mm] ".LO SJ" doesn't put a blank line after a letter's subject

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code