GNU GRUB - Bugs: bug #61718, util/grub.d/30_os-prober.in: only...
You are not allowed to post comments on this tracker with your current authentication level.
bug #61718: util/grub.d/30_os-prober.in: only print warning when os-prober is actually available
Submitter: | Christoph Anton Mitterer <calestyo> | ||
Submitted: | Thu 23 Dec 2021 04:29:01 AM UTC | ||
Category: | User Interface | Severity: | Major |
Priority: | 5 - Normal | Item Group: | None |
Status: | None | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Open | Release: | Git master |
Release: | Reproducibility: | Every Time | |
Planned Release: | None |
Attached Files
file #52556: 0001-30_os-prober.in-only-warn-if-os-prober-is-available.patch added by calestyo (2KiB - text/x-patch)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follows 1 latest change.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-12-23 | calestyo | Attached File | - | ![]() |
Added 0001-30_os-prober.in-only-warn-if-os-prober-is-available.patch, #52556 |
Hey.
In util/grub.d/30_os-prober.in you have:
if [ "x${GRUB_DISABLE_OS_PROBER}" = "xtrue" ]; then
grub_warn "$(gettext_printf "os-prober will not be executed to detect other bootable partitions.\nSystems on them will not be added to the GRUB boot configuration.\nCheck GRUB_DISABLE_OS_PROBER documentation entry.")"
exit 0
fi
followed by:
if ! command -v os-prober > /dev/null || ! command -v linux-boot-prober > /dev/null ; then
# missing os-prober and/or linux-boot-prober
exit 0
fi
why not switching the two, so that that annoying message is omitted, when the system doesn’t have os-prober installed anyway?
I would make a pull request... but... where? ^^
So attached is a patch created by git format-patch.
Cheers,
Chris.