bugGNU roff - Bugs: bug #53674, [PATCH] pdfpic.tmac: Neutralize...

 
 

bug #53674: [PATCH] pdfpic.tmac: Neutralize extra ".."

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Tue 17 Apr 2018 03:46:12 AM UTC
   
 
Category:  Macro - others/general Severity:  2 - Minor
Item Group:  Lint Status:  Fixed
Privacy:  Public Assigned to:  schwarze
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 18 Apr 2018 08:26:19 PM UTC, comment #1: 

Obviously, if a file contains two consecutive, identical lines,
it doesn't matter which one is removed.
I deleted the excess line, thanks for noticing.

Ingo Schwarze <schwarze>
Group Member
Tue 17 Apr 2018 03:46:12 AM UTC, original submission:  


From bca3c31ec15d5fb9fecfd8206b3ad83a296f9385 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Tue, 17 Apr 2018 03:34:00 +0000
Subject: [PATCH] pdfpic.tmac: Neutralize extra ".."

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---

troff: .../groff/build/../tmac/pdfpic.tmac:145: warning: macro '.' not defined

Extra ".." was added in commit 82630588fc32a5d2e00f257bc79cac7493e7e809

  If the right (first) ".." is deleted in the corrected file, "diff"
deletes the second (wrong) one, as it does not know which one to
delete.
  So a second commit (not provided by me) is needed to delete my change
(\#..)

 tmac/pdfpic.tmac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tmac/pdfpic.tmac b/tmac/pdfpic.tmac
index c3859bf1..d33a0d38 100644
--- a/tmac/pdfpic.tmac
+++ b/tmac/pdfpic.tmac
@@ -141,7 +141,7 @@ sed -e 's/Page *size: *\\([[:digit:].]*\\) *x *\\([[:digit:].]*\\).*$/\
 .    br
 .    sp \\n[pdf-desht]u
 .  \}
-..
+\#..
 ..
 .
 .cp \n[_C]
--
2.17.0


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by schwarze (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden Item GroupNone Lint
        Planned ReleaseNone 1.22.4
    2018-04-18 schwarze Severity3 - Normal 2 - Minor
        StatusNone Fixed
        Assigned toNone schwarze
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code