GNU GRUB - Bugs: bug #52637, ZFS enhancement suggestions?
You are not allowed to post comments on this tracker with your current authentication level.
bug #52637: ZFS enhancement suggestions?
Submitter: | lundman <lundman> | ||
Submitted: | Mon 11 Dec 2017 05:30:52 AM UTC | ||
Category: | Filesystem | Severity: | Major |
Priority: | 5 - Normal | Item Group: | Feature Request |
Status: | None | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Open | Release: | Git master |
Release: | Reproducibility: | None | |
Planned Release: | None |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
No changes have been made to this item
Powered by Savane 3.13-02a9.
Corresponding source code
Hello GRUB!
So I ported GRUB's ZFS support to U-boot in 2012, and have gone back to refresh it today. Excellent work, and thanks, on the new features, like lz4, and raidz booting!
While doing that work, I came across of few tiny things that perhaps would be appreciated in GRUB. (nits really..) But if this is just annoying noise, feel free to close this ticket.
Minor memory leak in rare error case, dmu_read() allocated zapbuf:
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2527
again at line 2598 and line 2639.
The directory listing code here:
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2113
passes the "mze_value" unmolested to (eventually) dnode_get(). But it should be filtered by ZFS_DIRENT_OBJ() as in:
https://github.com/lundman/u-boot/blob/master/fs/zfs/zfs.c#L2054
( used correctly in the file reading code: )
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2847
Which makes listing work here. But it confuses me a little that nobody has complained that listings do not work correctly in GRUB for non-Solaris pools, like ZOL?
That is all.