bugGNU troff - Bugs: bug #52335, src: Some warnings from the...

 
 

bug #52335: src: Some warnings from the compiler that need fixing or explanations in the code

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Sat 04 Nov 2017 12:25:21 AM UTC  
 
Category:  Core Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  1.22.4

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 18 Jun 2018 07:45:45 AM UTC, comment #7:
G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Sun 12 Nov 2017 03:20:39 PM UTC, comment #6:

I've pushed fixes for all of these except the sized destructor problem, for which I'm turning to the mailing list for help.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Sat 11 Nov 2017 03:42:29 AM UTC, comment #5:
Bjarni Ingi Gislason <bjarniig>
Sat 11 Nov 2017 03:19:11 AM UTC, comment #4:
Bjarni Ingi Gislason <bjarniig>
Fri 10 Nov 2017 01:11:29 PM UTC, comment #3:

The following quiets the sized-deallocation warning, but the most obvious solution (to me) causes a different warning.

Comments welcome.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Fri 10 Nov 2017 11:44:11 AM UTC, comment #2:

I think the instances in
src/preproc/grn/hdb.cpp are false positives as well.

We might be able to silence this warning by decorating fatal_error_exit() in src/libs/libgroff/fatal.cpp with _attribute_(noreturn), but I'm not positive.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Fri 10 Nov 2017 11:36:49 AM UTC, comment #1:

Hi Bjarni,

I believe fall-through is the correct behavior for groff.cpp, line 295.

However, I don't have GCC 7 handy. Can you test the following patch, please?

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Sat 04 Nov 2017 12:25:21 AM UTC, original submission:
Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-18 gbranden Open/ClosedOpen => Closed
    2018-06-18 gbranden CategoryNone => Core
        Item GroupNone => Build/Installation
        Planned ReleaseNone => 1.22.4
    2017-11-16 gbranden StatusNeed Info => Fixed
        Assigned toNone => gbranden
    2017-11-10 gbranden StatusNone => Need Info

    Back to the top


    Powered by Savane 3.4