bugGNUstep - Bugs: bug #51592, -[NSFileManager...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51592: -[NSFileManager copyItemAtPath:toPath:error:] should not raise exceptions

Submitted by:  Larry Campbell <lcampbel>
Submitted on:  Thu 27 Jul 2017 03:30:08 PM UTC  
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Tue 02 Jan 2018 12:49:52 PM UTC, comment #2:

Applied Gtraham's fix.

Richard Frith-Macdonald <CaS>
Project Member
Sun 26 Nov 2017 10:17:06 AM UTC, comment #1:

I created a pull request to address this: https://github.com/gnustep/libs-base/pull/16

Graham Lee <leeg>
Thu 27 Jul 2017 03:30:08 PM UTC, original submission:

At the top of _copyFile:toFile:handler:, we have this:

/* Assumes source is a file and exists! */
NSAssert1 ([self fileExistsAtPath: source],
@"source file '%@' does not exist!", source);

attributes = [self fileAttributesAtPath: source traverseLink: NO];
NSAssert1 (attributes, @"could not get the attributes for file '%@'",
source);

However, any other error causes the handler (if any) to be called and NO to be returned. I think these asserts should be replaced by something like:

if (!exists)
return [self _proceedAccordingToHandler: handler
forError: @"source file does not exist"
inPath: source
fromPath: source
toPath: destination];

Larry Campbell <lcampbel>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by leeg (Posted a comment)
  • -email is unavailable- added by FredKiefer (Updated the item)
  • -email is unavailable- added by lcampbel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-02 CaS StatusNone => Fixed
        Open/ClosedOpen => Closed
    2017-08-24 FredKiefer CategoryNone => Base/Foundation
        Item GroupNone => Bug

    Back to the top


    Powered by Savane 3.3