bugGNUstep - Bugs: bug #51592, -[NSFileManager...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51592: -[NSFileManager copyItemAtPath:toPath:error:] should not raise exceptions

Submitted by:  Larry Campbell <lcampbel>
Submitted on:  Thu 27 Jul 2017 03:30:08 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Sun 26 Nov 2017 10:17:06 AM UTC, comment #1:

I created a pull request to address this: https://github.com/gnustep/libs-base/pull/16

Graham Lee <leeg>
Thu 27 Jul 2017 03:30:08 PM UTC, original submission:

At the top of _copyFile:toFile:handler:, we have this:

/* Assumes source is a file and exists! */
NSAssert1 ([self fileExistsAtPath: source],
@"source file '%@' does not exist!", source);

attributes = [self fileAttributesAtPath: source traverseLink: NO];
NSAssert1 (attributes, @"could not get the attributes for file '%@'",
source);

However, any other error causes the handler (if any) to be called and NO to be returned. I think these asserts should be replaced by something like:

if (!exists)
return [self _proceedAccordingToHandler: handler
forError: @"source file does not exist"
inPath: source
fromPath: source
toPath: destination];

Larry Campbell <lcampbel>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by leeg (Posted a comment)
  • -unavailable- added by FredKiefer (Updated the item)
  • -unavailable- added by lcampbel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Aug 2017 07:35:17 PM UTCFredKieferCategoryNone=>Base/Foundation
      Item GroupNone=>Bug

    Back to the top


    Powered by Savane 3.1-cleanup1