bugGNU troff - Bugs: bug #51513, [PATCH] src: Add missing prototypes

 
 

bug #51513: [PATCH] src: Add missing prototypes

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Thu 20 Jul 2017 12:59:31 AM UTC  
 
Category:  Core Severity:  2 - Minor
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 11 Nov 2017 04:04:32 PM UTC, comment #5: 

Ah, I see, you reposted it as comment #2, without comment. :P

Thanks!

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Sat 11 Nov 2017 02:44:05 AM UTC, comment #4: 

  The missing content of comment #1:

>From d2afe3af191e7cd434a50408a90d9ba7a80c9108 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Wed, 26 Jul 2017 23:39:43 +0000
Subject: [PATCH] src: Add more missing prototypes

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
src/libs/libgroff/iftoa.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/src/libs/libgroff/iftoa.c b/src/libs/libgroff/iftoa.c
index 0919f5f6..a5cf684e 100644
--- a/src/libs/libgroff/iftoa.c
+++ b/src/libs/libgroff/iftoa.c
@@ -17,7 +17,9 @@ You should have received a copy of the GNU General Public
License
along with this program. If not, see <http://www.gnu.org/licenses/>. */

/* Prototype */
+char *i_to_a(int, int);
char *if_to_a(int, int);
+char *ui_to_a(int, int);

#define INT_DIGITS 19                /* enough for 64-bit integer */

--
2.13.2

Bjarni Ingi Gislason <bjarniig>
Fri 10 Nov 2017 02:01:12 PM UTC, comment #3: 

Comment #1 is missing its content.  Bjarni, can you provide the missing piece?

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Mon 31 Jul 2017 12:58:38 AM UTC, comment #2: 

From 7ded635104bcc80a5c890b34666583c8a1fe2b42 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Mon, 31 Jul 2017 00:54:38 +0000
Subject: [PATCH] src: itoa.c: add missing prototypes

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
src/libs/libgroff/itoa.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/src/libs/libgroff/itoa.c b/src/libs/libgroff/itoa.c
index fdeca06e..7ca16124 100644
--- a/src/libs/libgroff/itoa.c
+++ b/src/libs/libgroff/itoa.c
@@ -23,6 +23,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
extern "C" {
#endif

+/* Prototypes */
+
+char *i_to_a(int);
+char *ui_to_a(unsigned int);
+
char *i_to_a(int i)
{
   /* Room for INT_DIGITS digits, - and '\0' */
--
2.13.2

Bjarni Ingi Gislason <bjarniig>
Wed 26 Jul 2017 11:42:16 PM UTC, comment #1: 
Bjarni Ingi Gislason <bjarniig>
Thu 20 Jul 2017 12:59:31 AM UTC, original submission:  


From 1e700831a7e709d54a9d785bd2ac3bcfbbe709f1 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 20 Jul 2017 00:52:02 +0000
Subject: [PATCH] src: Add missing prototypes

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
src/libs/libbib/map.c        | 4 ++++
src/libs/libgroff/iftoa.c    | 3 +++
src/libs/libgroff/quotearg.c | 4 ++++
src/roff/groff/pipeline.c    | 4 ++++
src/utils/indxbib/signal.c   | 3 +++
5 files changed, 18 insertions(+)

diff --git a/src/libs/libbib/map.c b/src/libs/libbib/map.c
index c8d7962d..fca863c0 100644
--- a/src/libs/libbib/map.c
+++ b/src/libs/libbib/map.c
@@ -36,6 +36,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
extern "C" {
#endif

+/* Prototypes */
+char *mapread(int, int);
+int unmap(char *, int);
+
char *mapread(int fd, int nbytes)
{
   char *p = (char *)mmap((void *)0, (size_t)nbytes, PROT_READ,
diff --git a/src/libs/libgroff/iftoa.c b/src/libs/libgroff/iftoa.c
index 7f39fa07..0919f5f6 100644
--- a/src/libs/libgroff/iftoa.c
+++ b/src/libs/libgroff/iftoa.c
@@ -16,6 +16,9 @@ for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */

+/* Prototype */
+char *if_to_a(int, int);
+
#define INT_DIGITS 19                /* enough for 64-bit integer */

#ifdef __cplusplus
diff --git a/src/libs/libgroff/quotearg.c b/src/libs/libgroff/quotearg.c
index 535fce93..cd5f206d 100644
--- a/src/libs/libgroff/quotearg.c
+++ b/src/libs/libgroff/quotearg.c
@@ -43,6 +43,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */

extern char *program_name;        /* main program must define this */

+/* Prototypes */
+char *quote_arg(char *);
+void purge_quoted_args(char **);
+
#undef FALSE
#undef TRUE
#define FALSE 0
diff --git a/src/roff/groff/pipeline.c b/src/roff/groff/pipeline.c
index d988a8c9..1879af61 100644
--- a/src/roff/groff/pipeline.c
+++ b/src/roff/groff/pipeline.c
@@ -75,6 +75,10 @@ extern char *strerror();

#include "pipeline.h"

+/* Prototypes */
+int run_pipeline(int, char ***, int);
+
+
#define error c_error

#ifdef __cplusplus
diff --git a/src/utils/indxbib/signal.c b/src/utils/indxbib/signal.c
index 4ff6fa9b..16b411aa 100644
--- a/src/utils/indxbib/signal.c
+++ b/src/utils/indxbib/signal.c
@@ -31,6 +31,9 @@ that is correct for C++, so we implement all signal handling in C. */
#include <unistd.h>
#endif

+/* Prototype */
+void catch_fatal_signals(void);
+
#ifdef __cplusplus
extern "C" {
#endif
--
2.13.2

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-02 bgarrigues Open/ClosedOpen => Closed
    2017-11-11 gbranden StatusIn Progress => Fixed
    2017-11-11 gbranden StatusNeed Info => In Progress
    2017-11-10 gbranden StatusNone => Need Info
        Assigned toNone => gbranden
    2017-09-01 bgarrigues CategoryNone => Core
        Severity3 - Normal => 2 - Minor

    Back to the top


    Powered by Savane 3.5