bugGNU troff - Bugs: bug #51440, [PATCH] groff_diff.7.man: Fix...

 
 

bug #51440: [PATCH] groff_diff.7.man: Fix splitting of lines in bug #51327

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Tue 11 Jul 2017 01:53:11 PM UTC  
 
Category:  None Severity:  2 - Minor
Item Group:  Documentation Status:  Invalid
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 Nov 2017 08:25:33 AM UTC, comment #3: 

#51327 updated with your diff.

Closing this one as invalid (inapplicable to git HEAD or any release).

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Tue 11 Jul 2017 11:16:54 PM UTC, comment #2: 

Hi,

I just recently began to use and learn "git".
A correcting patch was for me the simplest approach.
I really don't know, how a comment about the wrong
escapes would have improved the issue, except sparing a new ticket.

  Maybe providing the correct patch as a comment to the first one would have
been the best bet.
I would myself still have to revert the first one in my copy and apply
the corrected patch.

  The escape '\c' is an old one, so I assume you mean the use of '.itc' in
the macro 'TP'.
I tested the source with both versions of the macro, and the result was the
same.

Bjarni Ingi Gislason <bjarniig>
Tue 11 Jul 2017 03:29:59 PM UTC, comment #1: 

Hi Bjarni,

your patch submitted in ticket #51327 is not committed yet, so why do you open a new ticket rather than merely adding a note to the existing ticket?

Also, using \c here harms portability.  It doesn't work except with very recent groff and mandoc.   So the better solution probably is to not split these lines at all, given that apparently eqn(1) cannot handle line continuation.

Ingo Schwarze <schwarze>
Project Member
Tue 11 Jul 2017 01:53:11 PM UTC, original submission:  

From cb6936f2eaa7b9ef0b119dc7a385f38470c3e9c1 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Tue, 11 Jul 2017 13:49:44 +0000
Subject: [PATCH] groff_diff.7.man: Fix splitting of lines in bug #51327

  This fixes some wrong use of an escape type to splitt lines in commit
'a918d83ec'.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
man/groff_diff.7.man | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/man/groff_diff.7.man b/man/groff_diff.7.man
index 17117dd9..db8f4684 100644
--- a/man/groff_diff.7.man
+++ b/man/groff_diff.7.man
@@ -3506,9 +3506,8 @@ delim $$
.EN
.
.TP
-\f[B]Dp\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ \
+\f[B]Dp\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ \c
$dx sub n$ $dy sub n$\[rs]n
-
Draw a polygon with, for $i = 1 ,..., n+1$, the
.IR i -th
vertex at the current position
@@ -3519,7 +3518,7 @@ At the moment, GNU pic only uses this command to generate triangles
and rectangles.
.
.TP
-\f[B]DP\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ $dx sub n$ \
+\f[B]DP\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ $dx sub n$ \c
$dy sub n$\[rs]n
.
Like
@@ -3552,8 +3551,8 @@ does not depend on this.
.
Given a drawing command of the form
.IP
-\f[B]\[rs]D'\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x \
-sub n$ $y sub n$\f[B]'\f[R]
+\f[B]\[rs]D'\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$
+$x sub n$ $y sub n$\f[B]'\f[R]
.
.P
where
@@ -3596,7 +3595,7 @@ Thus after executing a
.BR D \~\c
command of the form
.IP
-\f[B]D\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x sub n$ \
+\f[B]D\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x sub n$
$y sub n$\[rs]n
.
.P
--
2.13.2

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by schwarze (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-01 gbranden StatusNone => Invalid
        Assigned toNone => gbranden
        Open/ClosedOpen => Closed
    2017-09-01 bgarrigues Severity3 - Normal => 2 - Minor
        Item GroupNone => Documentation

    Back to the top


    Powered by Savane 3.5