GNU GRUB - Bugs: bug #46986, Fails to build on FreeBSD CURRENT...
You are not allowed to post comments on this tracker with your current authentication level.
bug #46986: Fails to build on FreeBSD CURRENT amd64
Submitter: | Kostya Berger <bergerkos> | ||
Submitted: | Wed 27 Jan 2016 01:19:24 AM UTC | ||
Category: | Compilation | Severity: | Major |
Priority: | 5 - Normal | Item Group: | None |
Status: | Fixed | Privacy: | Public |
Assigned to: | None | Originator Name: | bergerkos |
Open/Closed: | Closed | Release: | Git master |
Release: | Reproducibility: | Every Time | |
Planned Release: | None |
Jump to the original submission
Wed 03 Feb 2016 05:36:43 PM UTC, comment #20: |
Andrei Borzenkov <arvidjaar> |
Tue 02 Feb 2016 07:45:28 PM UTC, comment #19:
|
Andrei Borzenkov <arvidjaar> |
Fri 29 Jan 2016 10:37:04 PM UTC, comment #18: Sorry, I mean binutils-2.25.1. |
Kostya Berger <bergerkos> |
Fri 29 Jan 2016 10:34:24 PM UTC, comment #17: OK, my version of strip is part of elftoolchain which is used in FreeBSD for license-related reasons.
|
Kostya Berger <bergerkos> |
Thu 28 Jan 2016 08:55:11 PM UTC, comment #16: Yes, I can reproduce it with binutils 2.17 (it was a challenge just to compile them ...). Note that modern binutils actually always add section symbols. I am not sure what to do. I would like to know the reason why this behavior was changed. |
Andrei Borzenkov <arvidjaar> |
Wed 27 Jan 2016 09:37:37 PM UTC, comment #15: Here's objdump output for all_video.mod that builds with strip section removed in genmod.sh (for this particular module):
|
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 09:28:48 PM UTC, comment #14: Sorry, distorted output here. |
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 09:27:35 PM UTC, comment #13: Well, when I disable strip command in genmod.sh for all_video.mod it contains these symbols (same as all_video.module):
|
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 09:07:24 PM UTC, comment #12: Before module verifier this problem just resulted in unloadable module. You can disable check in module verifier but it will not do any good as runtime has the same check. And if you bypass check at runtime you're likely to bit a null pointer dereference. If we want to support symbolless modules we need more work to make them work. Alternative is to put a fake symbol |
Vladimir Serbinenko <phcoder> |
Wed 27 Jan 2016 09:03:15 PM UTC, comment #11: Don't know if it matters as I'm not a programmer... but genmod.sh has changed in the version that fails compared to the previous one.
|
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 08:26:11 PM UTC, comment #10: Doesn't build either. And here strip is GNU strip 2.17.50 |
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 08:08:49 PM UTC, comment #9: Sorry, I'm not a programmer, that's why.
|
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 07:56:15 PM UTC, comment #8: You misunderstand. It is clear what this script does. But either objcopy or strip removes more than expected. So you need to check result of these commands using "objdump -t" to see when symbol table gets lost.
|
Andrei Borzenkov <arvidjaar> |
Wed 27 Jan 2016 07:43:39 PM UTC, comment #7: Here is the debug output of the command you suggested:
|
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 07:07:49 PM UTC, comment #6: This is something with your toolchain. When I generate module from the same all_video.module sumbol table is preserved. Try to execute step by step manually (see grub-core/genmod.sh) to find out when it gets lost.
|
Andrei Borzenkov <arvidjaar> |
Wed 27 Jan 2016 06:40:25 PM UTC, comment #5: Here, configure output, too. |
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 06:38:22 PM UTC, comment #4: Here you are. |
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 05:40:41 PM UTC, comment #3: It does not really matter. Commit you mention introduced module verifier, which is why it is the first to fail. The problem is most likely in your toolchain, but we need to see what sections actually exist in object. I guess make output is not needed, but configure and config.log would be useful. |
Andrei Borzenkov <arvidjaar> |
Wed 27 Jan 2016 05:27:54 PM UTC, comment #2: For which build? For the last or for the first bad (i.e. a7cf8b1e235fbbc8a460510615c7ff85f21c2d05) ? |
Kostya Berger <bergerkos> |
Wed 27 Jan 2016 03:40:45 AM UTC, comment #1: Please attach all_video.module and all_video.mod.tmp (latter should be left by genmod.sh). Also full configure and make log. |
Andrei Borzenkov <arvidjaar> |
Wed 27 Jan 2016 01:19:24 AM UTC, original submission:
Fails to build. Git bisect shows first failing commit to be a7cf8b1e235fbbc8a460510615c7ff85f21c2d05
|
Kostya Berger <bergerkos> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-02-03 | arvidjaar | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2016-01-27 | bergerkos | Attached File | - | Added configure.output.txt, #36185 | |
2016-01-27 | bergerkos | Attached File | - | Added all_video.module, #36182 | |
Attached File | - | Added config.log, #36183 | |||
Attached File | - | Added all_video.mod.tmp, #36184 |
Powered by Savane 3.13-cf05.
Corresponding source code
Should be fixed in 67dba97e4598eaf2deb14da044fbfb1c119cf76f. Please reopen if needed. Thank you!