bugGNU GRUB - Bugs: bug #44734, Avoid hardcoding kernel param...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #44734: Avoid hardcoding kernel param "ro" in 10_linux

Submitted by:  Tom Yan <tomty89>
Submitted on:  Sun 05 Apr 2015 03:59:58 PM UTC  
 
Category:  Configuration Severity:  Major
Priority:  5 - Normal Item Group:  Action Request
Status:  None Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Open Release: 
Release:  Git master Reproducibility:  Every Time
Planned Release:  2.03+

Mon 10 Aug 2015 07:41:33 AM UTC, comment #3:

You (or some dev) can just remove the hardcode. Clean codebase wins :)

Whether rw is faster does not matter. What matters is the kernel has its own default and if users prefer otherwise they can change in grub.cfg or /etc/default/grub. Having either rw or ro in 10_linux is silly.

Tom Yan <tomty89>
Fri 07 Aug 2015 12:34:40 PM UTC, comment #2:

You can just add "rw" to kernel options. Last option wins.

Andrei Borzenkov <arvidjaar>
Project Member
Thu 30 Jul 2015 10:14:11 AM UTC, comment #1:

I agree. Sometimes it is faster to mount a FS "rw" directly rather than mounting "ro" first.

Erkin Alp G├╝ney <erkinalp>
Sun 05 Apr 2015 03:59:58 PM UTC, original submission:

http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub.d/10_linux.in#n132

There is no reason to hardcode any specific kernel param in the grub.d file. Any preference or recommendation can be written in /etc/default/grub.

Tom Yan <tomty89>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Updated the item)
  • -email is unavailable- added by arvidjaar (Posted a comment)
  • -email is unavailable- added by erkinalp (Posted a comment)
  • -email is unavailable- added by tomty89 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-02 phcoder Planned ReleaseNone => 2.03+

    Back to the top


    Powered by Savane 3.3