bugGNU GRUB - Bugs: bug #43633, Add format option for ip addresses...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43633: Add format option for ip addresses to net_get_dhcp_option

Submitted by:  Rob <rkliewer>
Submitted on:  Tue 18 Nov 2014 09:33:17 PM UTC  
 
Category: User InterfaceSeverity: Major
Priority: 3 - LowItem Group: Feature Request
Status: NonePrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: OpenRelease: 
Release: Git masterReproducibility: Every Time
Planned Release: 2.03+

Thu 22 Jan 2015 08:56:56 PM UTC, comment #3:

The patch has bugs. The least of them is memory leak. Please use ML for patches, not bugtracker.

Vladimir Serbinenko <phcoder>
Project Administrator
Thu 20 Nov 2014 03:25:16 AM UTC, comment #2:

Uploaded a new patch. Changes to bootp.c have been simplified and net_get_dhcp_option documentation has been updated.

(file #32481)

Rob <rkliewer>
Wed 19 Nov 2014 06:31:08 PM UTC, comment #1:

You do not really need endian conversion. Just print each byte directly.

grub_printf("%d.%d.%d.%d", ptr[0], ptr[1], ptr[2], ptr[3])

Please update documentation too.

Andrei Borzenkov <arvidjaar>
Project Member
Tue 18 Nov 2014 09:33:17 PM UTC, original submission:

There are a few ip addresses, not automatically set to variables, that may be needed in a grub config (such as netmask and default router). These may be retrieved with net_get_dhcp_option, but only as the decimal or hex representation of the 32-bit value. I have included a patch that adds a new format specification 'ip' to net_get_dhcp_option, allowing values to be displayed/saved as ip strings.

Rob <rkliewer>

 

Attached Files
file #32481:  add-ip-type-to-net-get-dhcp-option.patch added by rkliewer (2KiB - application/octet-stream)
file #32469:  bootp.c.patch added by rkliewer (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by arvidjaar (Posted a comment)
  • -unavailable- added by rkliewer (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 11 Oct 2016 12:45:58 PM UTCphcoderPriority5 - Normal=>3 - Low
    Wed 02 Mar 2016 10:48:18 AM UTCphcoderPlanned ReleaseNone=>2.03+
    Thu 20 Nov 2014 03:25:16 AM UTCrkliewerAttached File-=>Added add-ip-type-to-net-get-dhcp-option.patch, #32481
    Tue 18 Nov 2014 09:33:17 PM UTCrkliewerAttached File-=>Added bootp.c.patch, #32469

    Back to the top


    Powered by Savane 3.1-cleanup1