bugGNUstep - Bugs: bug #42729, [DBusKit] Unnecessary libtool usage

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #42729: [DBusKit] Unnecessary libtool usage

Submitted by:  Yavor Doganov <yavor>
Submitted on:  Fri 11 Jul 2014 01:26:11 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Item Group: InstallationStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Fri 11 Jul 2014 01:26:11 PM UTC, original submission:

DBusKit attempts to use libtool, but that is impossible as it stands. You either have to use Automake which has built-in support for libtool, or write/implement libtool-aware rules (which is not straightforward and would probably conflict with gnustep-make's rules). Furthermore, using libtool is not needed, because GNUstep Make supports shared libraries, albeit in a much less sophisticated manner.

DBUS_LIBS and MORE_LIBS should be added to LIBRARIES_DEPEND_UPON and not LDFLAGS so that the libs are added after the objects that are being linked in and not as linker options (that will fail on some systems).

Perhaps the test for libclang should be conditionalized and not performed if CC/OBJC is not clang (I have not addressed this in the patch as I'm not certain about the implications).

The 0.1.1 tarball contains a libtool script which should never be distributed (it is configuration-dependent). Also there are a bunch of object files which shouldn't be there, too.

Yavor Doganov <yavor>

 

Attached Files
file #31699:  no-libtool.patch added by yavor (673B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yavor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Jul 2014 01:26:11 PM UTCyavorAttached File-=>Added no-libtool.patch, #31699

    Back to the top


    Powered by Savane 3.1-cleanup