bugGNU GRUB - Bugs: bug #42134, loadenv.c – check_blocklists –...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #42134: loadenv.c – check_blocklists – algorithm for block overlap check is wrong

Submitted by:  Роман Пехов <roman_pekhov>
Submitted on:  Thu 17 Apr 2014 02:17:55 PM UTC  
Votes:  101  
 
Category:  Configuration Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  Fixed Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Closed Release: 
Release:  Git master Reproducibility:  Every Time
Planned Release:  None

Sun 22 Jun 2014 01:37:50 AM UTC, comment #1:

Committed, thanks.

Vladimir Serbinenko <phcoder>
Project Administrator
Thu 17 Apr 2014 02:17:55 PM UTC, original submission:

The check_blocklists function surely writes "malformed file" error if the block list contains more than one blocks.

The well-known overlap check algorithm is:

if (s1 < e2 && s2 < e1)
{
return grub_error (GRUB_ERR_BAD_FS, "malformed file");
}

Swap (s1 <-> s2, e1 <-> e2) is not needed in this case.

Роман Пехов <roman_pekhov>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by sharifm (Voted in favor of this item)
  • -email is unavailable- added by roman_pekhov (Voted in favor of this item)
  • -email is unavailable- added by roman_pekhov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 101 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-06-22 phcoder StatusNone => Fixed
        Open/ClosedOpen => Closed
    2014-05-18 sharifm Carbon-Copy- => Added sharifm
    2014-04-19 roman_pekhov Carbon-Copy- => Added roman_pekhov

    Back to the top


    Powered by Savane 3.3