bugGNU GRUB - Bugs: bug #42134, loadenv.c – check_blocklists –...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #42134: loadenv.c – check_blocklists – algorithm for block overlap check is wrong

Submitted by:  Роман Пехов <roman_pekhov>
Submitted on:  Thu 17 Apr 2014 02:17:55 PM UTC  
Votes:  101  
 
Category: ConfigurationSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: Git masterReproducibility: Every Time
Planned Release: None

Sun 22 Jun 2014 01:37:50 AM UTC, comment #1:

Committed, thanks.

Vladimir Serbinenko <phcoder>
Project Administrator
Thu 17 Apr 2014 02:17:55 PM UTC, original submission:

The check_blocklists function surely writes "malformed file" error if the block list contains more than one blocks.

The well-known overlap check algorithm is:

if (s1 < e2 && s2 < e1)
{
return grub_error (GRUB_ERR_BAD_FS, "malformed file");
}

Swap (s1 <-> s2, e1 <-> e2) is not needed in this case.

Роман Пехов <roman_pekhov>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by sharifm (Voted in favor of this item)
  • -unavailable- added by roman_pekhov (Voted in favor of this item)
  • -unavailable- added by roman_pekhov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 101 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Jun 2014 01:37:50 AM UTCphcoderStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 18 May 2014 02:03:31 AM UTCsharifmCarbon-Copy-=>Added sharifm
    Sat 19 Apr 2014 10:20:45 PM UTCroman_pekhovCarbon-Copy-=>Added roman_pekhov

    Back to the top


    Powered by Savane 3.1-cleanup