bugGNU GRUB - Bugs: bug #41030, grub-install does not check...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #41030: grub-install does not check arguments for sanity before proceeding

Submitted by:  <qwertial>
Submitted on:  Sun 29 Dec 2013 09:20:19 PM UTC  
 
Category: InstallationSeverity: Major
Priority: 5 - NormalItem Group: None
Status: NonePrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: OpenRelease: 
Release: Git masterReproducibility: Every Time
Planned Release: None

Mon 30 Dec 2013 01:43:47 AM UTC, comment #1:

Attempting to guess what the user might have wanted is the way to get spaghetti unextendable code resulting in unexpected result. E.g. grub-install C: already has a meaning: install to C PBR. Overloading it with other meanings will add ambiguity.

Vladimir Serbinenko <phcoder>
Project Administrator
Sun 29 Dec 2013 09:20:19 PM UTC, original submission:

To reproduce: run

grub-install --target=i386-pc --verbose /dev/bull

and observe that it copies modules before even establishing that /dev/bull is not an actual block device.

There's an opportunity for some "smart" behaviour here: for example, when given a directory (instead of a device node) as the installation target argument, GRUB could use it as if it were passed as --boot-directory, and install itself to the underlying partition's disk. (For the mingw port, specifying a drive letter in this way would be less awkward than using paths like \\?\PhysicalDrive0.) But this is just a suggestion.

Also, grub-install could check whether a configuration file exists in the boot directory, and prompt the user to create one (or just prompt unconditionally).

<qwertial>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by qwertial (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup