bugGNUstep - Bugs: bug #39299, PostgreSQL adaptor not linking...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #39299: PostgreSQL adaptor not linking correctly

Submitted by:  Graham Lee <leeg>
Submitted on:  Thu 20 Jun 2013 02:47:41 PM UTC  
 
Category: gdl2Severity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Sebastian Reitenbach <buzzdee>
Open/Closed: Closed

Sat 22 Jun 2013 03:29:55 PM UTC, comment #1:

patch is in svn rev 36742

thanks

Sebastian Reitenbach <buzzdee>
Project MemberIn charge of this item.
Thu 20 Jun 2013 02:47:41 PM UTC, original submission:

config.mak specifies -lEOControl -lEOAccess, which doesn't work when these are Mach-O frameworks. The GNUmakefile for the adaptor already tells -make to link these libraries anyway via ADDITIONAL_NATIVE_LIBS, so this entry is redundant.

This patch also removes some ambiguity from the log message generated to help diagnose this issue.

Index: EOAccess/EOAdaptor.m
===================================================================
--- EOAccess/EOAdaptor.m (revision 36733)
+++ EOAccess/EOAdaptor.m (working copy)
@@ -225,10 +225,11 @@
if(adaptorClass == Nil)
{
[NSException raise: NSInvalidArgumentException
- format: @"%@ -- %@ 0x%x: value of EOAdaptorClassName '%@' is not a valid class and bundle does not contain a principal class",
+ format: @"%@ -- %@ 0x%x: value of EOAdaptorClassName '%@' for adaptor '%@' is not a valid class and bundle does not contain a principal class",
NSStringFromSelector(_cmd),
NSStringFromClass([self class]),
self,
+ adaptorClassName,
name];
}

Index: EOAdaptors/PostgreSQLAdaptor/config.mak.in
===================================================================
--- EOAdaptors/PostgreSQLAdaptor/config.mak.in (revision 36733)
+++ EOAdaptors/PostgreSQLAdaptor/config.mak.in (working copy)
@@ -27,8 +27,7 @@
ADDITIONAL_INCLUDE_DIRS += @POSTGRES_INCLUDES@

# Libraries linked to the framework
-LIBRARIES_DEPEND_UPON += @POSTGRES_LIBS@ -lEOControl -lEOAccess $(FND_LIBS) \
- $(OBJC_LIBS)
+LIBRARIES_DEPEND_UPON += @POSTGRES_LIBS@ $(FND_LIBS) $(OBJC_LIBS)

# Additional library directories the linker should search
ADDITIONAL_LIB_DIRS += @POSTGRES_LIB_DIRS@

Graham Lee <leeg>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by buzzdee (Posted a comment)
  • -unavailable- added by leeg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Jun 2013 03:29:55 PM UTCbuzzdeeStatusNone=>Fixed
      Assigned toNone=>buzzdee
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup