bugGNUstep - Bugs: bug #38393, NSBezierPath does not have a...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #38393: NSBezierPath does not have a complete implementation of keyed archive coding

Submitted by:  Chris Armstrong <carmstrong>
Submitted on:  Sun 24 Feb 2013 06:28:42 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Tue 21 Jan 2014 08:07:00 AM UTC, comment #3:

No comment in almost a year.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 04 Mar 2013 04:52:44 PM UTC, comment #2:

I commited your patch plus the required change to -elementAtIndex:associatedPoints: plus the corresponding changes to the callers.

Please give it a try.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sun 24 Feb 2013 12:24:25 PM UTC, comment #1:

Thank you for this great patch. I would really love to add that to the upcoming gui release, even though we are in a code freeze.

There is one interesting aspect to your patch. For "close" elements you are using two points returned by elementAtIndex:associatedPoints: Now that method in GNUstep doesn't return any points for "close" elements and according to the Apple documentation it should return one.

This means that we have an important issue here in the current GNUstep code and that your code has an issue as well. Your issue could be easily fixed by using the same point twice. But where should that point come from? I think the best way to fix it now is to moce some code from currentPoint into the elementAtIndex:associatedPoints: method and later one rethink the whole code once more.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sun 24 Feb 2013 06:28:42 AM UTC, original submission:

gnustep-gui's implementation of NSBezierPath initWithCoder: and encodeWithCoder: is incomplete for keyed archive coding (i.e. with NSKeyedArchiver/NSKeyedUnarchiver.

I've attached a patch that completes the implementation.

Chris Armstrong <carmstrong>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by carmstrong (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Jan 2014 08:07:00 AM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Mon 04 Mar 2013 04:52:44 PM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test
    Sun 24 Feb 2013 06:28:42 AM UTCcarmstrongAttached File-=>Added NSBezierPath-keyedcodingimplementation.diff, #27516

    Back to the top


    Powered by Savane 3.1-cleanup