GNU GRUB - Bugs: bug #36640, Please make grub-probe support...
You are not allowed to post comments on this tracker with your current authentication level.
bug #36640: Please make grub-probe support symlinks
Submitter: | Sebastian Pipping <hartwork> | ||
Submitted: | Tue 12 Jun 2012 04:21:36 PM UTC | ||
Category: | None | Severity: | Major |
Priority: | 5 - Normal | Item Group: | None |
Status: | Fixed | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Closed | Release: | Bazaar - trunk |
Release: | Reproducibility: | None | |
Planned Release: | None |
Sat 16 Jun 2012 04:36:11 PM UTC, comment #4: |
Sebastian Pipping <hartwork> |
Thu 14 Jun 2012 02:39:46 PM UTC, comment #3: Please try this patch:
|
Vladimir Serbinenko <phcoder> |
Tue 12 Jun 2012 04:37:28 PM UTC, comment #2: I have verified to be running 2.0~beta6. In fact, I have it installed system-wide.
|
Sebastian Pipping <hartwork> |
Tue 12 Jun 2012 04:25:56 PM UTC, comment #1: Can't reproduce it here:
|
Vladimir Serbinenko <phcoder> |
Tue 12 Jun 2012 04:21:36 PM UTC, original submission:
Related to bug #36639 in a way.
|
Sebastian Pipping <hartwork> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2012-06-16 | phcoder | Status | None | Fixed | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-caa5.
Corresponding source code
Vladimir,
thanks for coming up with a patch so quickly! As you pasted the patch inline, copy-paste produced a malformed patch ..
# patch -p 0 < patch
patching file util/getroot.c
patch: ** malformed patch at line 4: ptr = ret + sizeof ("/dev/disk") + rdisk - 1;
.. with whitespace broken and even some '*'s missing.
I believed I was able to restore the patch correctly, see [1] for my result to be sure.
Fortunately, the patch seems to work well. I confirm all(?) possible combinations working:
# for d in /dev/loop7 /dev/GRUB_BOOT_TEST_DISK ; do \
for m in normal-device.map symlink-device.map \
both-a-b-device.map both-b-a-device.map '' ; do \
printf "[%s][%s] -> " "$d" "$m"; \
./grub-probe --device-map="$m" --target=drive \
--device "$d" ; \
done ; \
done
[/dev/loop7][normal-device.map] -> (hd0)
[/dev/loop7][symlink-device.map] -> (hd0)
[/dev/loop7][both-a-b-device.map] -> (hd0)
[/dev/loop7][both-b-a-device.map] -> (hd0)
[/dev/loop7][] -> (hostdisk//dev/loop7)
[/dev/GRUB_BOOT_TEST_DISK][normal-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][symlink-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][both-a-b-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][both-b-a-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][] -> (hostdisk//dev/loop7)
Best,
Sebastian
[1] http://hartwork.org/public/grub-issue-36640-restored.patch