bugGNUstep - Bugs: bug #35867, The NSFileManager's inconsistent...

Group
 
 

bug #35867: The NSFileManager's inconsistent manner of returning errors

Submitter:  Sergei Golovin <svg>
Submitted:  Sat 17 Mar 2012 07:11:52 AM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 08 Jul 2012 03:57:12 PM UTC, comment #1: 

Thanks, I applied changes based on your ideas.

Richard Frith-Macdonald <CaS>
Group Member
Sat 17 Mar 2012 07:11:52 AM UTC, original submission:  

I stuck once more with the issues like the one reported within
#35692. Some methods with the **NSError as an argument for to
populate it in the case of a fail leave this argument intact on
an error.

If I get it correctly there is the instance variable _lastError
for the case when one of NSFileManager's conditions checks fails
and there is no related failed calls to a system library (so the
call [NSError _last] does not make sense for getting NSError
object). The variable isn't used in the current code besides
assigning. I utilize it by the patch to get the arguments
**NSError consistently populated either by use of the value
_lastError or by calling [NSError _last].
Also there is another patch adding more tests for that.

Sergei Golovin <svg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25378:  gs_base_nsfilemanager.patch added by svg (10KiB - text/x-patch - The patches)
file #25379:  gs_base_Tests_Base_NSFileManager.patch added by svg (8KiB - text/x-patch - The patches)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by svg (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-07-08 CaS StatusNone Fixed
        Open/ClosedOpen Closed
    2012-03-17 svg Attached File- Added gs_base_nsfilemanager.patch, #25378
        Attached File- Added gs_base_Tests_Base_NSFileManager.patch, #25379

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code