bugGNUstep - Bugs: bug #34835, Harmfull sed search/replace calls...

Group
 
 

bug #34835: Harmfull sed search/replace calls in pathtls.m4 and pathxml.m4

Submitter:  Felix Geyer <debfx>
Submitted:  Tue 15 Nov 2011 05:29:41 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 19 Jan 2012 09:38:17 AM UTC, comment #1: 

Agreed ... thanks for pointing this out.
I modified those files as suggested.

Richard Frith-Macdonald <CaS>
Group Member
Tue 15 Nov 2011 05:29:41 PM UTC, original submission:  

config/pathtls.m4 and config/pathxml.m4 in gnustep-base contain harmful sed search/replace calls:
XML_LIBS=`echo $XML_LIBS | sed -e 's|-L/usr/lib||'`

This completely breaks if libxml is in a subpath of /usr/lib (e.g. /usr/lib/x86_64-linux-gnu):

configure:9998: x86_64-linux-gnu-gcc -o conftest -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -I/usr/include/libxml2 -D_FORTIFY_SOURCE=2 -I/usr/include/GNUstep -I/usr/local/include/GNUstep -I/usr/local/include/GNUstep -Wl,-z,defs -Wl,--as-needed -L/usr/lib -L/usr/local/lib -L/usr/local/lib conftest.c /x86_64-linux-gnu -lxml2 -lffi -lrt -ldl  -lpthread -lz >&5
x86_64-linux-gnu-gcc: error: /x86_64-linux-gnu: No such file or directory

There is absolutely no harm in passing -L/usr/lib to the linker so please remove that sed call.

Felix Geyer <debfx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by debfx (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-01-19 CaS StatusNone Fixed
        Open/ClosedOpen Closed
    2011-11-15 debfx Attached File- Added configure_drop_harmful_sed_call.patch, #24382

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code