bugGNUstep - Bugs: bug #34780, Bogus interface styles in header

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #34780: Bogus interface styles in header

Submitted by:  Richard Frith-Macdonald <CaS>
Submitted on:  Wed 09 Nov 2011 06:42:44 AM UTC  
 
Category: Gui/AppKitSeverity: 2 - Minor
Item Group: BugStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Sun 13 May 2012 09:29:48 PM UTC, comment #3:

I removed the GSNativeInterfaceStyle. We should make sure we have a theme that fully replaces GSWindowMakerInterfaceStyle before we remove that too.

Fred Kiefer <FredKiefer>
Project Member
Tue 15 Nov 2011 12:31:57 AM UTC, comment #2:

I believe that the GSWindowMakerInterfaceStyle was added via a patch by Micheal Hanni which I applied.

As for the GSNativeInterfaceStyle, this should be removed. I believe it was an early attempt by me to provide a way for us to specify that GNUstep should use the native menu format, whatever that might be.

GC

Gregory John Casamento <gcasa>
Project Administrator
Mon 14 Nov 2011 01:29:10 PM UTC, comment #1:

If two interface styles are really the same and if they should be the same, better remove one (of course the non-standard GS*). That way the temptation to make them diverge doesn't arise.
Just my 2cents-

Riccardo Mottola <rmottola>
Project Member
Wed 09 Nov 2011 06:42:44 AM UTC, original submission:

Looking into bug #34777 I noticed that the NSInterfaceStyle.h header now has two new, non-standard interface styles added.
I think these should be removed before someone starts trying to use them and have code that depends on them!

There's really no justification for adding new styles when we have theming, and having new styles can really only lead to compatibility and maintainability problems.

I see GSWindowMakerInterfaceStyle which appears to do nothing but adjust the position of submenus... it would surely make more sense to detect the presence of WindowMaker, but even using a single user default to turn it on/off would be better than exposing it as an API option.

Also, there's GSNativeInterfaceStyle which seems to be a synonym for NSNoInterfaceStyle

Richard Frith-Macdonald <CaS>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by gcasa (Posted a comment)
  • -unavailable- added by rmottola (Posted a comment)
  • -unavailable- added by CaS (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup