bugGNU GRUB - Bugs: bug #33424, resource leak & redundant...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33424: resource leak & redundant cehck in emu/hotdisk.c

Submitter:  David Volgyes <dvolgyes>
Submitted:  Sun 29 May 2011 08:39:31 AM UTC
   
 
Category:  None Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  Fixed Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Closed Release:  Bazaar - trunk
Release:  Reproducibility:  Every Time
Planned Release:  None

Thu 23 Jun 2011 08:05:14 PM UTC, comment #1: 

Second part fixed. First part isn't of any real trouble.

Vladimir Serbinenko <phcoder>
Group administrator
Sun 29 May 2011 08:39:31 AM UTC, original submission:  

Cppcheck found two bugs in hotdisk.c, both of them are real bugs.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:674]: (error) _linux_ is already guaranteed to be defined

#ifdef _linux_
was in a "#ifdef _linux_" section.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:1773]: (error) Resource leak: fd

fd was not closed before "return".

Patch is submitted.

David Volgyes <dvolgyes>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #23463:  hotdisk.patch added by dvolgyes (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by dvolgyes (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-06-23 phcoder StatusNone Fixed
        Open/ClosedOpen Closed
    2011-05-29 dvolgyes Attached File- Added hotdisk.patch, #23463

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code