GNU GRUB - Bugs: bug #32472, Shouldn't use sync ()
You are not allowed to post comments on this tracker with your current authentication level.
bug #32472: Shouldn't use sync ()
Submitter: | Коренберг Марк <socketpair> | ||
Submitted: | Mon 14 Feb 2011 09:31:27 AM UTC | ||
Category: | Installation | Severity: | Major |
Priority: | 5 - Normal | Item Group: | Software Error |
Status: | Fixed | Privacy: | Public |
Assigned to: | None | Originator Name: | Коренберг Марк |
Open/Closed: | Closed | Release: | 1.98 |
Release: | Reproducibility: | Every Time | |
Planned Release: | None |
Jump to the original submission
Mon 25 Apr 2011 05:40:30 PM UTC, comment #19: |
Vladimir Serbinenko <phcoder> |
Mon 25 Apr 2011 04:12:38 PM UTC, comment #18: What I was checked:
|
Коренберг Марк <socketpair> |
Mon 25 Apr 2011 12:09:41 PM UTC, comment #17:
You can try it yourself. Comment all the calls to grub_util_biosdisk_flush and try to install in blocklist mode (e.g. onto partition using --force). |
Vladimir Serbinenko <phcoder> |
Mon 25 Apr 2011 11:44:08 AM UTC, comment #16:
|
Коренберг Марк <socketpair> |
Mon 25 Apr 2011 11:08:47 AM UTC, comment #15:
Calling grub_util_biosdisk_flush in grub-setup makes the difference between failed and successfull install |
Vladimir Serbinenko <phcoder> |
Mon 25 Apr 2011 09:31:13 AM UTC, comment #14: I have found some errors in code and provide a patch:
|
Коренберг Марк <socketpair> |
Fri 22 Apr 2011 06:01:26 PM UTC, comment #13: Okay, just what I want to see :) Thanks. Really.
|
Коренберг Марк <socketpair> |
Fri 22 Apr 2011 01:15:05 PM UTC, comment #12: I went ahead and fixed this before rc2 since it created a real problem |
Vladimir Serbinenko <phcoder> |
Fri 15 Apr 2011 07:11:17 AM UTC, comment #11: Remaining part is postponed after 1.99 |
Vladimir Serbinenko <phcoder> |
Fri 15 Apr 2011 04:56:38 AM UTC, comment #10: bump. Please reopen bug. |
Коренберг Марк <socketpair> |
Sun 10 Apr 2011 04:27:31 PM UTC, comment #9: open_device():
|
Коренберг Марк <socketpair> |
Sun 10 Apr 2011 04:14:04 PM UTC, comment #8: Also, i'm not
|
Коренберг Марк <socketpair> |
Sun 10 Apr 2011 03:41:10 PM UTC, comment #7:
No, it's not true.
|
Коренберг Марк <socketpair> |
Sun 10 Apr 2011 02:08:16 PM UTC, comment #6: Thanks for reporting (2), fixed. Sync is still needed though because we do FS writes as well (e.g. creating/modifying core.img, copying modules) |
Vladimir Serbinenko <phcoder> |
Sat 09 Apr 2011 02:31:02 PM UTC, comment #5:
I mean:
|
Коренберг Марк <socketpair> |
Sat 09 Apr 2011 02:28:02 PM UTC, comment #4: Okay, you just replace close() with fsync() + ioctl.
|
Коренберг Марк <socketpair> |
Sat 09 Apr 2011 02:14:17 PM UTC, comment #3: It's in bzr. r3178 |
Vladimir Serbinenko <phcoder> |
Sat 09 Apr 2011 02:03:19 PM UTC, comment #2: Did not found changes in bzr.... how I can look to your changes? |
Коренберг Марк <socketpair> |
Fri 08 Apr 2011 12:01:22 PM UTC, comment #1: fixed. |
Vladimir Serbinenko <phcoder> |
Mon 14 Feb 2011 09:31:27 AM UTC, original submission:
It is safer to call fsync() on FD connected to device [flush kernel cache]. After which, ioctl(BLKFLSBUF) should follow [flush hardware cache]. This sequence guaranteed data flushing.
|
Коренберг Марк <socketpair> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-04-25 | socketpair | Attached File | - | Added z.patch, #23298 | |
2011-04-22 | phcoder | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2011-04-15 | phcoder | Status | Fixed | None | |
Open/Closed | Closed | Open | |||
Summary | GRUB2 does not flush data correctly after installing | Shouldn't use sync () | |||
2011-04-10 | socketpair | Attached File | - | Added z.patch, #23191 | |
2011-04-08 | phcoder | Status | None | Fixed | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-f8d8.
Corresponding source code
You don't have partitions.