bugGNUstep - Bugs: bug #31983, GSDragView.m...

Group
 
 

bug #31983: GSDragView.m draggingSourceOperationMaskForLocal:

Submitter:  Banlu Kemiyatorn <id>
Submitted:  Sun 26 Dec 2010 09:22:07 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 27 Dec 2010 01:47:02 PM UTC, comment #3: 

Looks like Apple changed that from 10.5 to 10.6.

I made a few changes to the class and now all the calls to the dragging source should check whether the method is actually implemented. I also added a call to draggedImage:movedTo:.

All these checks should be cached on the GSDragView as they wont change for the same dragging source.

Fred Kiefer <FredKiefer>
Group Member
Mon 27 Dec 2010 12:15:04 PM UTC, comment #2: 

I read from

http://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Protocols/NSDraggingSource_Protocol/Reference/Reference.html

draggingSourceOperationMaskForLocal:

[..]

Discussion
"If not implemented, the default value is NSDragOperationCopy |
NSDragOperationLink | NSDragOperationGeneric |
NSDragOperationPrivate."

Banlu Kemiyatorn <id>
Mon 27 Dec 2010 11:54:29 AM UTC, comment #1: 

Acoording to Apples documentation this is a method that has to be implemented all of the times:

"This method is the only NSDraggingSource method that must be implemented by the source object."

If this statement from the documentation does not match the actual implementation in Cocoa I am willing to change the code otherwise, we better leave it the way it is now.

Fred Kiefer <FredKiefer>
Group Member
Sun 26 Dec 2010 09:22:07 PM UTC, original submission:  

GSDragView.m:649

dragMask = [dragSource draggingSourceOperationMaskForLocal: !destExternal];

should query and if not implemented, return
NSDragOperationLink|NSDragOperationCopy|NSDragOperationGeneric|NSDragOperationPrivate.

Banlu Kemiyatorn <id>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by id (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-10-03 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2010-12-27 FredKiefer StatusInvalid Ready For Test
        Open/ClosedDeclined In Test
    2010-12-27 FredKiefer StatusNone Invalid
        Assigned toNone FredKiefer
        Open/ClosedOpen Declined

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code