bugGNUstep - Bugs: bug #30724, To determine FixPitch trait we...

Group
 
 

bug #30724: To determine FixPitch trait we need to ask for spacing infomation.

Submitter:  Derek Fawcus <dfawcus>
Submitted:  Tue 10 Aug 2010 08:09:11 AM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Ready For Test
Privacy:  Public Assigned to:  gcasa
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 21 Oct 2014 01:12:13 PM UTC, comment #2: 

No comment by the original owner, I suppose the bug is fixed.

Riccardo Mottola <rmottola>
Group Member
Tue 10 Aug 2010 07:28:22 PM UTC, comment #1: 

Thank you for this simple patch. Should be fixed in SVN now.

Fred Kiefer <FredKiefer>
Group Member
Tue 10 Aug 2010 08:09:11 AM UTC, original submission:  

The Xft fontconfig enumerator (the the cairo one based on it) share a bug in that the FixPitch trait is not correctly calculated.  This is because it depends upon the presense of the FC_SPACING attribute,  and only those attributes explicitly requested are included in the results from the search.

The below patch is against the refactored version of the code I've not yet shown,  however it is obvious how to manually apply it to both the Xft and Cairo code.

Author: Derek Fawcus <dfawcus@employees.org>
Date:   Thu Aug 5 22:18:09 2010 +0100

    To determine FixPitch trait we need to ask for spacing infomation.

diff --git a/Source/x11/FcFontEnumerator.m b/Source/x11/FcFontEnumerator.m
index 9a76bea..9bdd49f 100644
--- a/Source/x11/FcFontEnumerator.m
+++ b/Source/x11/FcFontEnumerator.m
@@ -144,7 +144,7 @@ static NSArray *faFromFc(FcPattern *pat)
   NSMutableArray *fc_allFontNames = [[NSMutableArray alloc] init];

   FcPattern *pat = FcPatternCreate();
-  FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT, NULL);
+  FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT, FC_SPACING, NULL);
   FcFontSet *fs = FcFontList(0, pat, os);

   FcPatternDestroy(pat);


Derek Fawcus <dfawcus>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by dfawcus (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-10-21 rmottola Open/ClosedIn Test Closed
    2010-08-10 FredKiefer StatusNone Ready For Test
        Assigned toNone gcasa
        Open/ClosedOpen In Test

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code