bugGNUstep - Bugs: bug #30511, the change to NSString.m in r31003...

Group
 
 

bug #30511: the change to NSString.m in r31003 is wrong for NSString subclasses

Submitter:  Doug Simons <theeggcamefirst>
Submitted:  Wed 21 Jul 2010 09:23:59 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 22 Jul 2010 06:11:58 AM UTC, comment #1: 

I reverted that change entirely ... as far as I can see it's totally wrong.

Judging by the comment in the subversion log, It may have been intended as a hack to wallpaper over a bug in NSProxy/NSInvocation ... but there's no evidence of such a bug on my machines (though I haven't tested on a 64bit CPU).

Richard Frith-Macdonald <CaS>
Group Member
Wed 21 Jul 2010 09:23:59 PM UTC, original submission:  

This change breaks equality testing for my subclass of NSString. Two strings which are equal (one of which is an instance of my custom subclass of NSString, and the other an instance of GSCInlineString) now return NO to the isEqual: method.

Perhaps what was meant was to test [aString isKindOfClass:[NSString class]] rather than [aString isKindOfClass:[self class]]? I just tried that change and it fixes the problem for me, but I don't understand the intent of this line.


Doug Simons <theeggcamefirst>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by theeggcamefirst (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-22 CaS StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code