bugGNUstep - Bugs: bug #30069, Some images drawn offset on...

Group
 
 

bug #30069: Some images drawn offset on Windows since r30523

Submitter:  Doug Simons <theeggcamefirst>
Submitted:  Mon 07 Jun 2010 04:36:46 PM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  qmathe
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 23 Jun 2010 05:07:45 PM UTC, comment #3: 

Fantastic! It appears to be working perfectly now. Thank you, Quentin!

Doug Simons <theeggcamefirst>
Tue 22 Jun 2010 10:42:59 PM UTC, comment #2: 

Hi Doug,

This issue should now be fixed with r30829

Various limitations still remain. -compositeGState and related -compositeToPoint: methods are broken in a way similar to Cairo. When the context is rotated, the origin is wrong.

Alpha blending doesn't work in some cases (rotated or scaled context but I'm not sure), I just get a yellow rectangle.

-drawInRect: and similar methods from NSImage now work correctly in a rotated/scaled context, the image is now drawn at the right location.

I initially wrote a patch that corrects the -compositeGState issue and is also a bit cleaner that the one I committed. But because of a weird issue I discuss in the -DPSimage note comment, I had to give up this approach.

Given this GDI backend should be deprecated in favor of Opal/Cairo at some point, I don't think putting more effort in improving it is worth the investment.

Let me know if you encounter any issue with the changes I committed,
Quentin.

Quentin Mathé <qmathe>
Group Member
Sat 19 Jun 2010 02:49:40 PM UTC, comment #1: 

Just let you know… I'm still working on it, but it's harder than expected.

Quentin Mathé <qmathe>
Group Member
Mon 07 Jun 2010 04:36:46 PM UTC, original submission:  

The changes made to the drawing code in r30523 cause some images to be drawn lower on the screen than they should on Windows, as shown in these screen shots of an image in a tableView:

http://www.testplant.com/img/Before30523.png
http://www.testplant.com/img/After30523.png


Doug Simons <theeggcamefirst>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Updated the item)
  • -email is unavailable- added by qmathe (Posted a comment)
  • -email is unavailable- added by theeggcamefirst (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-26 FredKiefer StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2010-06-22 qmathe CategoryGui/AppKit Backend
        StatusNone Ready For Test
        Assigned toNone qmathe

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code