bugGNU GRUB - Bugs: bug #29007, "error: unknown command...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29007: "error: unknown command `terminal'" if terminal_output gfxterm is false

Submitter:  Colin Watson <cjwatson>
Submitted:  Thu 25 Feb 2010 02:59:40 PM UTC
   
 
Category:  Configuration Severity:  Ordinary
Priority:  5 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  phcoder Originator Name:  Colin King
Open/Closed:  Closed Release:  Bazaar - trunk
Release:  Reproducibility:  None
Planned Release:  None

Mon 02 Aug 2010 06:47:56 PM UTC, comment #1: 

2010-07-20  Vladimir Serbinenko  <phcoder@gmail.com>

        * util/grub.d/00_header.in: Remove compatibility with terminal.mod
        prior to terminal_input/terminal_output separation. It's been over 1.5
        years and those versions weren't widely deployed.

Colin Watson <cjwatson>
Group Member
Thu 25 Feb 2010 02:59:40 PM UTC, original submission:  

In https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/519358, Colin King reports:

grub2 on an EFI firmware based machine reports the error message: "error: uknown command `terminal'".

I believe this occurs because "terminal_output gfxterm" fails to initialise (because we cannot probe or set the graphics mode) and then grub2 falls back to trying to be backwardly compatible with terminal.mod that does not support terminal_output by executing the non-existent command "terminal gfxterm".

The offending code is:

   if terminal_output gfxterm ; then true ; else
    # For backward compatibility with versions of terminal.mod that don't
    # understand terminal_output
    terminal gfxterm
  fi

A possible workaround that stops the error message is:

  if terminal_output gfxterm ; then true ; else
    # For backward compatibility with versions of terminal.mod that don't
    # understand terminal_output
    if terminal gfxterm ; then
      true
    fi
  fi

This seems to fix the problem on an EFI firmware based PC. I hope this does not break the backward compatibility terminal.mod workaround too.

Colin Watson <cjwatson>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cjwatson (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-02 cjwatson StatusNone Fixed
        Assigned toNone phcoder
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code