bugGNUstep - Bugs: bug #27635, Themes do not set title bar color...

Group
 
 

bug #27635: Themes do not set title bar color correctly

Submitter:  Stef <stefanbidi>
Submitted:  Fri 09 Oct 2009 02:32:11 AM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 12 Oct 2009 11:54:22 PM UTC, comment #7: 

Works great, now.  Thanks

Stef <stefanbidi>
Group Member
Mon 12 Oct 2009 03:13:40 PM UTC, comment #6: 

Together with Richards changes to catalogue colours this problem should be solved now. Please give the SVN code a try.

Fred Kiefer <FredKiefer>
Group Member
Sun 11 Oct 2009 05:48:40 PM UTC, comment #5: 

It's working for me, but I haven't tried creating new themes.  One this I did notice, and this might be a different bug, is that if I go from one theme to another some text color doesn't change correctly.

As an example, this is what I did to see this behavior:

  • Set theme to WinClassic--everything worked as expected;
  • Set it to ThinkDark (in GAP's CVS)--again, worked as expected;
  • Went back to WinClass... this time most of the theme changed, but the menu text color were still white (ThinkDark's default text color).  After restarting the application the text color was as expected: black.
Stef <stefanbidi>
Group Member
Sun 11 Oct 2009 05:01:43 PM UTC, comment #4: 

I had forgotten to remove the connection to the notification centre in the dealloc method. Just added this, please give it another try.

Fred Kiefer <FredKiefer>
Group Member
Sun 11 Oct 2009 02:00:19 PM UTC, comment #3: 

I updated.

Now if I run Thematic, make a new theme and set the "Window frame" color, I get a crash. The same is true for the Window background.

#0  0x2875fa64 in objc_msg_lookup () from /usr/lib/libobjc.so.3
#1  0x2833922f in -[GSStandardWindowDecorationView(GSTheme) _themeDidActivate:]
    (self=0x28f03688, _cmd=0x28432df0, notification=0x294d2e28)
    at GSStandardWindowDecorationView.m:401
#2  0x285a317e in -[NSNotificationCenter _postAndRelease:] (self=0x28f51178,
    _cmd=0x287018c0, notification=0x294d2e28) at NSNotificationCenter.m:1161
#3  0x285a23cf in -[NSNotificationCenter postNotificationName:object:userInfo:]
    (self=0x28f51178, _cmd=0x284123a8, name=0x28412700, object=0x2941aff8,
    info=0x0) at NSNotificationCenter.m:1220
#4  0x282eade4 in -[GSTheme activate] (self=0x2941aff8, _cmd=0x8068218)
    at GSTheme.m:439
#5  0x0804c04e in -[ThemeDocument activate] (self=0x2948a6d8, _cmd=0x80685b8)
    at ThemeDocument.m:224
#6  0x0804f513 in -[ThemeDocument setColor:forKey:] (self=0x2948a6d8,
    _cmd=0x8070f30, color=0x29432a08, key=0x8070f84) at ThemeDocument.m:1188
#7  0x0805fb3e in -[ColorElement takeColorFrom:] (self=0x290ea558,
    _cmd=0x28f1bb98, sender=0x290b9eb8) at ColorElement.m:43
#8  0x28cd4897 in ffi_call_SYSV () from /usr/local/lib/libffi.so.5
#9  0x28cd46de in ffi_call (cif=0x294a0040,
    fn=0x805fa60 <-[ColorElement takeColorFrom:]>, rvalue=0x2946b6d0,
    avalue=0x294a0078) at src/x86/ffi.c:213
#10 0x28666fb5 in GSFFIInvokeWithTargetAndImp (_inv=0x2946b6a8,
    anObject=0x290ea558, imp=0x805fa60 <-[ColorElement takeColorFrom:]>)
    at GSFFIInvocation.m:392

Riccardo Mottola <rmottola>
Group Member
Sat 10 Oct 2009 05:41:13 PM UTC, comment #2: 

I made the GSStandardWindowDecorationView react to theme changes, it should now redraw itself. I also moved the whole drawing code over to GSTheme to make it easier to write different drawing code. And removed the caching of the title background colour (but not that of the font colour).
The remaining missing bit for full theme support in that class is the ability to get the position of the buttons from the theme, but that would also be easy.

I am not sure, whether my change resolves the issue you had, I don't have any themes installed on my computer. So please test and report back.

Fred Kiefer <FredKiefer>
Group Member
Fri 09 Oct 2009 08:41:41 AM UTC, comment #1: 

Both the windows title bar as well as the windows frame color do not change on the fly. It is an "issue" also while developing with Thematic, since these changes are visible only later.

For example, the Windows Classic theme sets the grey tone brighter, to adapt to the standard Windows one you can see this only after restarting the application.

Riccardo Mottola <rmottola>
Group Member
Fri 09 Oct 2009 02:32:11 AM UTC, original submission:  

I started playing with Riccardo's themes and started seeing some funny things.  I'm using GSX11HandlesWindowDecorations = NO (I never remember what the new default is and http://www.gnustep.org/resources/documentation/Developer/Back/General/DefaultsSummary.html has not been updated) so I'm seeing GNUstep version of a title bar.

Really easy to reproduce and it happens always.  I originally set the theme to Neos (green title bar) but only after I restarted the application did I see that.  Then, I moved to WinClassic, and the title bar color did not change to blue until I restarted the app again.  All other colors and images are replaced "on-the-fly", except for the title bar color.

Stef <stefanbidi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by stefanbidi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-12-07 FredKiefer CategoryNone Gui/AppKit
    2009-10-13 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2009-10-12 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code