bugGNUstep - Bugs: bug #26438, First application does not get a...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #26438: First application does not get a proper app icon under Window Maker

Submitted by:  Wolfgang Lux <wlux>
Submitted on:  Sun 03 May 2009 09:50:39 PM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: BugStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Thu 29 May 2014 11:16:35 PM UTC, comment #3:

Sadly, this bug still holds.
For most applications it is not so evident. But for an application like a battery monitor it means that iw will show an icon instead of the actual status!

Riccardo Mottola <rmottola>
Project Member
Mon 19 Apr 2010 01:12:27 PM UTC, comment #2:

been a while since i've looked at this, so this may be hogwash.

IIRC the way appicons work in windowmaker is somewhat odd.

in the ICCCM if you look at...
4.1.2.4. WM_HINTS Property
where it talks about the initial_state hint it only describes behaviours for IconicState and NormalState,

iirc windowmaker does something special when the first window is mapped with its initial_state to WithdrawnState.
making that window the app icon window...

this happens in -orderwindow::: after the comment...
/* If we are asked to set hints for the appicon

i'm kinda confused on one thing, it looks like 'UseWindowmakerIcons = NO' default shouldn't really work anymore since the following patch, I mean... it looks like we create the windowmaker icon... but just don't send it any events in XGServerEvent or something... maybe wlux was just talking about the effect he would expect from UseWindowmakerIcons = NO?
anyhow, i haven't tried it.

https://savannah.gnu.org/patch/?5434

anyhow further down in XGServerWindow.m:-orderwindow:::
the comment starting with...
/* This doesn't appear to do anything useful, and, at least

iirc this line ensured that the first window mapped was the icon window, it could possibly be refined to aleviate the problems which caused it to be commented out.

it probably 'doesn't appear to do anything' because -gui was creating/mapping the app-icon window first anyways until the offset checks...

matt rice <ratmice>
Project Member
Mon 19 Apr 2010 10:52:43 AM UTC, comment #1:

I tired to figure out how our interaction with Window Maker works and failed to understand it. How will Window Maker know that we don't provide our own icons? The flag UseWindowMakerIcons is only used internally, I don't see a way to tell this to Window Maker. There also isn't much difference in how we create normal windows and the ones used to determine the style offset. The only difference I could spot is that we don't request NSIconWindowMask | NSMiniWindowMask in the style of the check windows. And I would have thought this is the right thing to do. So why is Window Maker creating an app icon for these windows? To me this seems to be more of an Window Maker issue than a GNUstep one.

I am not using Window Maker, so I wont be able to look into this issue at all. If somebody is interested in solving this I am willing to help though.

Fred Kiefer <FredKiefer>
Project Member
Sun 03 May 2009 09:50:39 PM UTC, original submission:

The first application started in an X-Windows session using Window Maker as window manager does not get a proper app icon and application menu. Instead, the standard Window Maker application menu is shown when right clicking the app icon as if the application was started with UseWindowMakerIcons = NO. If the user default GSIgnoreRootOffsets is set to YES this happens for every application.
Obviously, the problem is the code in XGServer's -_setupRootWindow method that attempts to determine the dimensions of the window frame added by the window manager. This code creates a few windows before the application creates its app icon. Apparently, Window Maker creates a standard app icon with its own menu when it becomes aware of the first of these windows and then ignores the later request for a custom app icon from the application.
I'm not sure what a good fix for this problem is. Of course, we could always special case Window Maker and just fix the window frame offsets for Window Maker (hoping that they will never change :-). Maybe the backend could always create an app icon window in advance before testing the window frame offsets and then later use this window instead of creating a new one when the application wants to create the real app icon window.

Wolfgang Lux <wlux>

 

No files currently attached

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by rmottola (Posted a comment)
  • -unavailable- added by ratmice (Posted a comment)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by wlux (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 30 Jan 2010 01:55:42 PM UTCFredKieferDependencies-=>bugs #28465 is dependent

    Back to the top


    Powered by Savane 3.1-cleanup