bugGNUstep - Bugs: bug #26339, FlexibleSpace Toolbar items don't...

Group
 
 

bug #26339: FlexibleSpace Toolbar items don't calculate their space correctly

Submitter:  Jonathan Gillaspie <jonathanosx>
Submitted:  Fri 24 Apr 2009 07:42:39 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 18 May 2010 07:49:05 PM UTC, comment #7: 

The basic issue is solved (the second time already) and now Doug has taken up this problem. Enough reason to close the original request.

Fred Kiefer <FredKiefer>
Group Member
Sat 30 Jan 2010 02:29:08 PM UTC, comment #6: 

The original author hasn't reported back in half a year. Does this mean we can close this bug report now, as the original cause of the problem has been fixed?

Fred Kiefer <FredKiefer>
Group Member
Fri 07 Aug 2009 07:02:32 AM UTC, comment #5: 

I rearranged some of the code for NSToolbarItem, at least now your own item will try to rescale itself, but the way this gets done probably wont be what you expect. Could you please give it a try and report back?

You will have to move to the current SVN version of GNUstep to test this. For this reason any pre-compiled version of Eggplant wont help me reproduce it.
It would be great, if you could publish the code for your NSToolbarItem subclass that has the resize feature (most likely including the corresponding view). Of course stripped down to just that :-)

Fred Kiefer <FredKiefer>
Group Member
Tue 28 Jul 2009 09:18:30 PM UTC, comment #4: 

Thank you for the reply, now I can see the problem even without looking at your code.
The code in [GSToolbarView _takeInAccountFlexibleSpaces] only checks for the GNUstep private Method _isFlexibleSpace, instead it should sum up the minimum and maximum space for each item and divide the available space according to these values.
The general idea is quite clear, but the actual implementation will be a bit difficult, as we need default values for these sizes for all the standard toolbar items.

Fred Kiefer <FredKiefer>
Group Member
Tue 28 Jul 2009 07:16:05 AM UTC, comment #3: 

Sorry Fred, I didn't see the notification of your comments at the time.  But let me answer your questions the best I can.

The problem happens with SVN reference checkout -r28233, although recent tests show that the problem is still there. (-r28395)

The problem manifests in Eggplant for Linux which is a commercial app and can be downloaded but the source isn't public.  Eggplant is a port of a Mac OS X cocoa application; it doesn't override any toolbar or toolbar item classes although it does have toolbar items which offer specific views (eg drop-down menus).  Please contact me via email if you would like a license key for the application. 

Playing around with it, the problem tends to occur when there are also toolbar items with variable width views that themselves have some stretching enabled.

Jonathan Gillaspie <jonathanosx>
Group Member
Tue 28 Jul 2009 06:35:28 AM UTC, comment #2: 

There hasn't been any reply to my questions. If this continues I will have to close this bug as invalid.
We can only resolve bugs for which we have sufficient information otherwise we end up chasing after application problems that aren't related to GNUstep itself.

Fred Kiefer <FredKiefer>
Group Member
Fri 01 May 2009 08:11:39 PM UTC, comment #1: 

Which versions of the GNUstep libraries are you using and which application shows this behaviour?

I tried to reproduce the problem with gui from SVN and the Bean application from gap and there the flexible space toolbar item behaves as expected.

If you are experiencing this problem with a specific application, could you please provide the source code of this application?

Fred Kiefer <FredKiefer>
Group Member
Fri 24 Apr 2009 07:42:39 PM UTC, original submission:  

NSToolbarFlexibleSpaceItemIdentifier seems to take ALL available space and push items off the right end of the toolbar (they should only take free space after toolbar items have been placed)

Jonathan Gillaspie <jonathanosx>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by jonathanosx (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-18 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2010-01-30 FredKiefer StatusConfirmed Ready For Test
        Open/ClosedOpen In Test
    2009-08-07 FredKiefer StatusNeed Info Confirmed
    2009-05-01 FredKiefer StatusNone Need Info
        Assigned toNone FredKiefer

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code