bugGNUstep - Bugs: bug #26244, fileOwnerAccountID and...

Group
 
 

bug #26244: fileOwnerAccountID and fileGroupOwnerAccountID should return an NSNumber

Submitter:  Doug Simons <theeggcamefirst>
Submitted:  Sun 19 Apr 2009 08:39:02 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 20 Apr 2009 03:56:45 PM UTC, comment #4: 

@Doug: could you please test this with your app?

Fred Morcos <fredmorcos>
Mon 20 Apr 2009 03:56:15 PM UTC, comment #3: 

Submitted an rewritten patch for fileOwnerAccountID and fileGroupOwnerAccountID. Everything works fine now.

Thanks to Ginormica for all the help with this patch.

(file #17975)

Fred Morcos <fredmorcos>
Mon 20 Apr 2009 01:50:53 PM UTC, comment #2: 

Applications don't start with the patch, here is a sample output:

   1.
      [fred:back]$ openapp Gorm
   2.
      2009-04-20 04:24:45.032 Gorm[8323] Failed to lock names for NSMessagePortNameServer
   3.
      2009-04-20 04:24:45.033 Gorm[8323] Exception occured while loading model: Failed to lock names for NSMessagePortNameServer
   4.
      2009-04-20 04:24:45.033 Gorm[8323] Failed to load Gorm
   5.
      2009-04-20 04:24:45.033 Gorm[8323] Could not load Gorm file: /usr/GNUstep/Local/Applications/Gorm.app/Resources/English.lproj/Gorm.gorm
   6.
      2009-04-20 04:24:45.096 Gorm[8323] XShm pixmaps not supported by X server.
   7.
      2009-04-20 04:24:45.096 Gorm[8323] Falling back to normal XImage: s (will be slower).
   8.
      2009-04-20 04:24:45.173 Gorm[8323] Font not found Courier
   9.
      2009-04-20 04:24:45.173 Gorm[8323] The font specified for NSUserFixedPitchFont, Courier, can't be found.
  10.
      2009-04-20 04:24:47.262 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  11.
      2009-04-20 04:24:49.266 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  12.
      2009-04-20 04:24:51.270 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  13.
      2009-04-20 04:24:53.275 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  14.
      2009-04-20 04:24:55.279 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  15.
      2009-04-20 04:24:57.283 Gorm[8323] Failed to lock names for NSMessagePortNameServer
  16.
      ^C^C^C^C^C^C2009-04-20 04:25:14.115 Gorm[8323] Failed to lock user defaults database even after breaking old locks!

grepping on all files in the Gorm source tree, nothing directly uses fileOwnerAccountID nor fileGroupOwnerAccountID... No sure what is wrong.

Fred Morcos <fredmorcos>
Mon 20 Apr 2009 01:35:31 PM UTC, comment #1: 

The patch for fileOwnerAccountID and fileGroupOwnerAccountID break everything if not modified and rebuilt against them.

Fred Morcos <fredmorcos>
Sun 19 Apr 2009 08:39:02 PM UTC, original submission:  

In NSFileManager, to be compatible with Cocoa the dictionary convenience methods fileOwnerAccountID and fileGroupOwnerAccountID should return an NSNumber, not an unsigned long. Needless to say, this little difference causes my Cocoa app to get a Segmentation Fault when it tries to get the intValue of the "NSNumber".  :-)

While you're at it, you might also want to change fileHFSCreatorCode and fileHFSTypeCode to return unsigned int rather than int, although this won't cause anyone to crash.

Doug Simons <theeggcamefirst>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #17975:  gnustep-base-nsfilemanager-fileowneraccountid-filegroupowneraccountid-2.patch added by fredmorcos (4KiB - text/x-patch - Everything works now. Replaces file #17973: gnustep-base-nsfilemanager-fileowneraccountid-filegroupowneraccountid.patch.)
file #17973:  gnustep-base-nsfilemanager-fileowneraccountid-filegroupowneraccountid.patch added by fredmorcos (5KiB - text/x-patch - Patch for Base to fix the fileOwnerAccountID and fileGroupOwnerAccountID)
file #17970:  gnustep-nsdictionary-nsfileattributes-filehfscreatorcode-filehfstypecode.diff added by fredmorcos (1KiB - text/plain - Here is a simple patch for fileHFSCreatorCode and fileHFSTypeCode)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Updated the item)
  • -email is unavailable- added by fredmorcos (Updated the item)
  • -email is unavailable- added by theeggcamefirst (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-24 CaS StatusNone Fixed
        Open/ClosedOpen Closed
    2009-04-20 fredmorcos Attached File- Added gnustep-base-nsfilemanager-fileowneraccountid-filegroupowneraccountid-2.patch, #17975
    2009-04-20 fredmorcos Attached File- Added gnustep-base-nsfilemanager-fileowneraccountid-filegroupowneraccountid.patch, #17973
    2009-04-20 fredmorcos Attached File- Added gnustep-nsdictionary-nsfileattributes-filehfscreatorcode-filehfstypecode.diff, #17970

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code