bugGNUstep - Bugs: bug #24845, Resizes of views in Gorm not...

Group
 
 

bug #24845: Resizes of views in Gorm not working properly...

Submitter:  Gregory John Casamento <gcasa>
Submitted:  Sat 15 Nov 2008 03:10:06 AM UTC
   
 
Category:  Gui/AppKit Severity:  4 - Important
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 16 Nov 2008 05:48:01 PM UTC, comment #7: 

I tried with the latest and it works properly now.

Thanks! :)  GC

Gregory John Casamento <gcasa>
Group administrator
Sun 16 Nov 2008 01:47:43 PM UTC, comment #6: 

Please try again with latest code in SVN. This showed a bug in the changes I made for SNView bounds setting. In the non-rotated case the bounds transformation matrix could get out of sync with the bounds.

Fred Kiefer <FredKiefer>
Group Member
Sat 15 Nov 2008 08:50:03 PM UTC, comment #5: 

Those are to make sure that if the size of the editor (which is a view which encloses the view it's editing) is modified that the edited view gets modified as well.

Those are what I'm referring to.

I simplified it when Iwas trying to diagnose this issue to just call the setFrame: method and I'm still getting a problem.

GC

Gregory John Casamento <gcasa>
Group administrator
Sat 15 Nov 2008 04:28:25 PM UTC, comment #4: 

Could you please hint me to the Gorm code involved? What I found is GormViewEditor with calls like:

  [self setFrame: [_editedObject frame]];
  [self setBounds: [_editedObject frame]];


Is this what you are talking about? In that case, I will need to inspect just those two methods on NSView.

Fred Kiefer <FredKiefer>
Group Member
Sat 15 Nov 2008 03:48:06 PM UTC, comment #3: 

Gorm doesn't override any of these methods, but it does listen for resize notifications.   All it does in those cases is resize the contained view (if it's an editor that was resized) and does not alter any of the calculations which are done.

When I resize a editor view in Gorm, the subview ends up being displaced by exactly the amount I resized by.   That is to say if I have a box and I resize it's editor, then the box is moved down from the top right corner by about half the amount of the resize.   This didn't happen before. 

The reason gorm listens for this notification and does the resize manually is because it needs to preserve the view resize flags for when the edited object is actually running in a program.

GC

Gregory John Casamento <gcasa>
Group administrator
Sat 15 Nov 2008 09:18:01 AM UTC, comment #2: 

Does Gorm override any of these methods? If so, the implementation may need some adjustment. I hope to have time to inspect this later today.

If the code in gui turns out to be wrong, could you please add a test in the testsuit? I am trying to build up comprehensiv test for frame and bounds transformations, as this is an old open issue for GNUstep gui and we need a complete and correct solution here.

Fred Kiefer <FredKiefer>
Group Member
Sat 15 Nov 2008 03:13:04 AM UTC, comment #1: 

2008-11-11 Fred Kiefer <FredKiefer@gmx.de>

        * Source/NSView.m (-setBoundsOrigin:, -setBoundsRotation:,
        -translateOriginToPoint:, -scaleUnitSquareToSize:,
        -rotateByAngle:): Reimplemented correctly.
        * Source/NSView.m (-_computeScale): New method.
        * Source/NSView.m (-_updateBoundsMatrix:, -setBounds:,
        -setBoundsSize:): Small changes.

I have traced it to being triggered by this change.   I'm not sure what's wrong at this point, still investigating.

Gregory John Casamento <gcasa>
Group administrator
Sat 15 Nov 2008 03:10:06 AM UTC, original submission:  

When trying to resize a view in Gorm it causes the editor view to move to the lower left of the window and the original view is lost.

Steps to reproduce:
1) open Gorm
2) create a new document
3) drag an NSBox into the NSWindow
4) try to resize it.
result: The original NSBox is lost.
expected: It should be properly resized.



Gregory John Casamento <gcasa>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by gcasa (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-11-16 gcasa Open/ClosedIn Test Closed
    2008-11-16 FredKiefer CategoryGorm Gui/AppKit
        StatusNone Fixed
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2008-11-15 gcasa Severity3 - Normal 4 - Important

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code