bugGNUstep - Bugs: bug #24564, build failure on solaris

Group
 
 

bug #24564: build failure on solaris

Submitter:  Riccardo Mottola <rmottola>
Submitted:  Tue 14 Oct 2008 09:38:55 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 Oct 2008 04:53:53 AM UTC, comment #1: 

Thanks ...I changed that as suggested.

Richard Frith-Macdonald <CaS>
Group Member
Tue 14 Oct 2008 09:38:55 PM UTC, original submission:  

on solaris 2.5, gcc 2.95, I get:

GSSocketStream.m: In function `-[GSSocketStream _setSocketAddress:port:family:]':
GSSocketStream.m:1394: warning: implicit declaration of function `inet_pton'
GSSocketStream.m: In function `-[GSSocketInputStream close]':
GSSocketStream.m:1683: `SHUT_RD' undeclared (first use in this function)
GSSocketStream.m:1683: (Each undeclared identifier is reported only once
GSSocketStream.m:1683: for each function it appears in.)
GSSocketStream.m: In function `-[GSSocketInputStream _dispatch]':
GSSocketStream.m:1900: warning: passing arg 4 of `getsockopt' from incompatible pointer type

I propose the following for the SHUT_RD missing:
#ifndef SHUT_RD
#define SHUT_RD 0
#define SHUT_WR 1
#define SHUT_RDWR 2
#endif

I have seen that in old code often the numbers were used directly and the modern manpage explicitely state that those values are hard-coded.

Or maybe a more expensive configure check should be used?

Riccardo Mottola <rmottola>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by rmottola (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-10-15 CaS StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code