bugGNU GRUB - Bugs: bug #24154, [patch] Wrong implementation of...


You are not allowed to post comments on this tracker with your current authentication level.

bug #24154: [patch] Wrong implementation of grub_video_vbe_scroll

Submitted by:  Tomas Tintera <trosos>
Submitted on:  Thu 28 Aug 2008 10:03:07 AM UTC  
Category:  None Severity:  Major
Priority:  5 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  Vesa Jääskeläinen <chaac> Originator Name:  Tomas Tintera
Open/Closed:  Closed Release:  svn-2008-08-28
Release:  None Reproducibility:  None
Planned Release:  None

Sun 01 Feb 2009 09:34:15 AM UTC, comment #2: 

Applied. Thaks.

Vesa Jääskeläinen <chaac>
Project MemberIn charge of this item.
Wed 03 Sep 2008 07:08:42 PM UTC, comment #1: 

I am currently integrating some other patches to that code and after that I have a look your patch. If you do not hear me in a month, ping on this tracker ;)

Vesa Jääskeläinen <chaac>
Project MemberIn charge of this item.
Thu 28 Aug 2008 10:03:07 AM UTC, original submission:  

Hi all,

while reading the source, I noticed that the
grub_video_vbe_scroll function seems not to work if used
with 0 < dy < (render_target->viewport.height / 2).
If we scroll down, we must begin at the bottom and continue
upwards, or else we would overwrite some memory before we
read it, which would give undesirable results (please
correct me if I am wrong).

(However, this situation so far never happens (because
grub_video_vbe_scroll() is only used to scroll up the text),
leaving this bug unreproducible).

The patch is attached.

In the patch, I changed the type of the variable j, thinking
that it is a mistype, as I noticed you use the type unit32_t
in that context anywhere else.

Best regards,
Tomas "trosos" Tintera

Tomas Tintera <trosos>


Attached Files
file #16376:  vbe.diff added by trosos (2KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by chaac (Posted a comment)
  • -email is unavailable- added by trosos (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-02-01 chaac StatusNone => Fixed
        Open/ClosedOpen => Closed
    2008-09-03 chaac Assigned toNone => chaac
    2008-08-28 trosos Attached File- => Added vbe.diff, #16376

    Back to the top

    Powered by Savane 3.7