bugGNUstep - Bugs: bug #23702, GNUstep.sh and GNUstep.csh puts...

Group
 
 

bug #23702: GNUstep.sh and GNUstep.csh puts /usr/bin at the beginning of PATH

Submitter:  Funda Wang <fundawang>
Submitted:  Wed 25 Jun 2008 04:51:35 AM UTC
   
 
Category:  Makefiles Severity:  3 - Normal
Item Group:  Bug Status:  None
Privacy:  Public Assigned to:  nico
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 27 Oct 2008 01:17:35 PM UTC, comment #3: 

OK - I didn't get any feedback - I'll assume that everything
is working fine

Please open a new issue if there are any problems :-)

Thanks

Nicola Pero <nico>
Group Member
Tue 21 Oct 2008 03:10:28 PM UTC, comment #2: 

Hi

I fixed this in trunk.  Can you please see if it works any
better now ? :-)

Thanks

Nicola Pero <nico>
Group Member
Sat 05 Jul 2008 11:14:39 AM UTC, comment #1: 

That is a very good bug report.

I agree the GNUstep.sh should not add paths that are already
there in the PATH.

In fact, it's supposed to already do it ;-) ... but instead
of checking each path separately (eg, checking that
/home/fwang/GNUstep/Tools is already in the PATH, checking that
/usr/bin is already in the PATH etc) it checks them all as
a block (ie, it checks that /home/fwang/GNUstep/Tools:/usr/bin:...
as a single, big string, is not already in the PATH).

I think that might have worked in v1 when all the paths where
stuff like /usr/GNUstep/System/Tools etc. but with v2 some
paths could be (as in your case) /usr/bin or such that are
already in the PATH while other paths aren't.

We'll rewrite the code and improve it so that it does the
right thing for 2.0.7

Thanks

Nicola Pero <nico>
Group Member
Wed 25 Jun 2008 04:51:35 AM UTC, original submission:  

/usr/share/GNUstep/Makefiles/GNUstep.sh will puts /usr/bin at the beginning of the PATH. The result is:

PATH="/home/fwang/GNUstep/Tools:/usr/bin:/usr/lib/icecc/bin:/usr/local/bin:/bin:/usr/bin:/usr/games:/usr/lib/qt4/bin:/opt/kde3/bin:/usr/lib/firebird/bin:/home/fwang/bin"

It adds "$HOME/GNUstep/Tools:/usr/bin:/usr/lib/icecc/bin" to the beggining of PATH, which will confuse programs installed in /usr/local/bin, as they will be ignored by preceed /usr/bin.

Is it possible considering current PATH order before setting PATH? i.e., dropping the PATH if it is already listed in current PATH. Or, put those additional PATH at the end of PATH?

Funda Wang <fundawang>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nico (Posted a comment)
  • -email is unavailable- added by fundawang (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-10-27 nico Open/ClosedOpen Closed
    2008-07-05 nico Assigned toNone nico

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code