bugGNUstep - Bugs: bug #20003, Two patches for packaging a...

Group
 
 

bug #20003: Two patches for packaging a relatively rpmlint clean gnustep-make rpm

Submitter:  Gareth Armstrong <garmstrong>
Submitted:  Tue 29 May 2007 02:13:24 PM UTC
   
 
Category:  Makefiles Severity:  3 - Normal
Item Group:  Bug Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 12 Mar 2008 05:21:38 PM UTC, comment #2: 

Wile I was to port sope/sogo to gnustep-make 2. I overhauled the configure script regarding the library directory name detection, according to the FHS standard, as I understood it. Below the code snippet, where I decide whether it should go into lib or lib64. Also the BSD's do not have that lib64/lib woes at all, at least OpenBSD I know of.
I have to admit, I did not took a look into the patches, so don't know whether you address this or not.

  UNAME=`uname`
  if [ "X${UNAME}" = "XLinux" ];then
    UNAME=`uname -p`
    if [ ${UNAME} = x86_64 -o ${UNAME} = sparc64 -o ${UNAME} = ppc64 ];then
      cfgwrite "CGS_LIBDIR_NAME:=lib64"
    else
      cfgwrite "CGS_LIBDIR_NAME:=lib"
    fi
  else
    cfgwrite "CGS_LIBDIR_NAME:=lib"
  fi


Sebastian Reitenbach <buzzdee>
Group Member
Thu 17 Jan 2008 02:50:59 AM UTC, comment #1: 

Thanks - excellent suggestions. :-)

I applied most of your changes/patches to trunk :-)

The main modification I made to your patches was not to install
GNUstep.sh and similar files as executables, but rather strip
out the initial shebang.  The file must be sourced - simply
executing it does nothing even if new users sometime try to do it
- so I'd rather have it installed as non-executable and without
any shebangs to make it really hard for users to do the wrong
thing and execute them instead of sourcing them ;-)

Anyway, great help, well done! :-)

Thanks

Nicola Pero <nico>
Group Member
Tue 29 May 2007 02:13:24 PM UTC, original submission:  

Hello Everyone,

I am in the process of packaging gnustep-make and gnustep-base rpm packages for RHEL 4 and 5 for my organization.  First of all, a big thank you for making it possible to select a more standard filesystem layout via the "./configure --with-layout=fhs-system" option.

Anyway, on to the current problems.  In my attempt to create a "rpmlint clean" gnustep-make rpm (based on the Fedora packaging policy), I needed to add the two attached patches to the packaging spec file (also attached).

The "gnustep-make-2.0.0-gnumakefile.in.patch" patch essentially gets me from these rpmlint errors (10) and warnings (3),

rpmlint /usr/src/redhat/RPMS/noarch/gnustep-make-2.0.1-1.ocek.el4.noarch.rpm
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/java-executable.template 0644
W: gnustep-make devel-file-in-non-devel-package /usr/bin/gnustep-config
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/filesystem.csh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/GNUstep.sh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/ld_lib_path.sh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/filesystem.sh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/app-wrapper.template 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/executable.template 0644
W: gnustep-make non-conffile-in-etc /etc/profile.d/gnustep.csh
W: gnustep-make non-conffile-in-etc /etc/profile.d/gnustep.sh
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/GNUstep.csh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/GNUstep-reset.sh 0644
E: gnustep-make non-executable-script /usr/share/GNUstep/Makefiles/ld_lib_path.csh 0644

to these 3 warning ;-)

rpmlint usr/src/redhat/RPMS/noarch/gnustep-make-2.0.1-1.ocek.el4.noarch.rpm
W: gnustep-make devel-file-in-non-devel-package /usr/bin/gnustep-config
W: gnustep-make non-conffile-in-etc /etc/profile.d/gnustep.csh
W: gnustep-make non-conffile-in-etc /etc/profile.d/gnustep.sh

The patch makes sense, (i.e. install -m 755), in that files like "/usr/share/GNUstep/Makefiles/GNUstep.sh"
contain a shebang, e.g.
#! /bin/echo This file must be sourced inside (ba)sh using: .

Similarly for the app-wrapper.template, executable.template and
ava-executable.template files.

The second patch, "gnustep-make-2.0.0-fhs-system-doc.patch" correctly positions the GNUSTEP_SYSTEM_DOC_MAN and GNUSTEP_SYSTEM_DOC_INFO variables to use /usr/share/man and /usr/share/info when "./configure --with-layout=fhs-system" is used.  This is the standard filesystem layout for both Red Hat and Debian based systems.  This patch is NOT directly needed by the gnustep-make rpm but IS to correctly package gnustep-base which is dependent on gnustep-make for the filesystem info.

Hopefully, this gives enough information as to the reasons for the two patches.  If you have any questions please don't hesitate to get back to me.  Feedback on the spec file would also be greatly appreciated.  I would at a future date like to push the packages to the Fedora community.  Many thanks again.

All the best,

Gareth



Gareth Armstrong <garmstrong>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #12894:  gnustep-make.spec added by garmstrong (6KiB - application/octet-stream - gnustep-make spec file and associated patches)
file #12895:  gnustep-make-2.0.0-fhs-system-doc.patch added by garmstrong (577B - text/x-patch - gnustep-make spec file and associated patches)
file #12896:  gnustep-make-2.0.0-gnumakefile.in.patch added by garmstrong (2KiB - text/x-patch - gnustep-make spec file and associated patches)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by buzzdee (Posted a comment)
  • -email is unavailable- added by nico (Posted a comment)
  • -email is unavailable- added by garmstrong (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-01-17 nico Open/ClosedOpen Closed
    2007-05-29 garmstrong Attached File- Added gnustep-make.spec, #12894
        Attached File- Added gnustep-make-2.0.0-fhs-system-doc.patch, #12895
        Attached File- Added gnustep-make-2.0.0-gnumakefile.in.patch, #12896

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code