bugGNUstep - Bugs: bug #19761, NSSecureTextField does not draw...

Group
 
 

bug #19761: NSSecureTextField does not draw bullets

Submitter:  -Deleted Account- <yjchen>
Submitted:  Mon 30 Apr 2007 11:11:31 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  gcasa
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 09 Nov 2008 03:20:57 PM UTC, comment #3: 

Applied and tested.   It works very well.  If we can, at a later date, use a glyph generator for this (which I believe is the right solution) then we should replace it.  Until then, this solution should suffice.

Thanks Saso & Fred.

Gregory John Casamento <gcasa>
Group administrator
Sun 09 Nov 2008 12:07:17 AM UTC, comment #2: 

Added the patch from Saso, plus the email discussion. Feel free to apply the patch, as I never get around to write a special glyph generator for this.

Fred





It's primarily meant to just replace the stars with real bullets. The
fact that it may perform faster is near to no meaning, given the
typically tiny data set being manipulated.

--
Saso

Fred Kiefer wrote:

> > Hi Saso,
> >
> > thank you for this patch. It just arrived a few weeks to late  :-)
> > I recently implemented the needed behaviour on GSLayoutManager and
> > NSGlyphGenerator. Now we are able to use a specific glyph generator
> > for the secure text fields. I just wanted to wait some time with
> > implementing this until the code in NSGlyphGenerator has gotten better
> > tested, otherwise I may have to revert this change.
> >
> > What I did not understand about your patch was the first bit where you
> > changed the generation of the replacement string. Is your code just a
> > bit faster or is there any other reason for the change? OK, you use a
> > bullet instead of a star. Is it that? I am asking, as this part of the
> > patch is still relevant.
> >
> > Fred
> >
> > Saso Kiselkov wrote:
>> >> Hi
>> >>
>> >> I've prepared a simple patch which implements bullet echoing in secure
>> >> text fields. It's a done in a rather stupid way, but it's functional.
>> >>
>> >> Regards
>> >> --
>> >> Saso
>> >>


(file #16803)

Fred Kiefer <FredKiefer>
Group Member
Sat 08 Nov 2008 11:34:59 PM UTC, comment #1: 

Fred,

I recall there was a patch for this, but it was postponed since there were changes pending to the text system.   What's the current status of the text system changes?

GC

Gregory John Casamento <gcasa>
Group administrator
Mon 30 Apr 2007 11:11:31 PM UTC, original submission:  

NSSecureTextField has no implementation for -setEchosBullets:.
It is commented in the source code, too.

-Deleted Account- <yjchen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #16803:  bullet.patch added by FredKiefer (3KiB - text/x-diff - Saso's original patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Updated the item)
  • -email is unavailable- added by gcasa (Updated the item)
  • -email is unavailable- added by yjchen (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-11-09 gcasa StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2008-11-09 FredKiefer Attached File- Added bullet.patch, #16803
    2007-05-19 gcasa StatusNone In Progress
        Assigned toNone gcasa

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code