bugGNUstep - Bugs: bug #17713, Popup Menu does not work on modal...

Group
 
 

bug #17713: Popup Menu does not work on modal window with EWMH window manager

Submitter:  -Deleted Account- <yjchen>
Submitted:  Wed 13 Sep 2006 12:07:23 AM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 13 Sep 2006 05:34:46 AM UTC, comment #2: 

Thanx.
As for the window types,
the problem is the when gui asks backend to create a window,
backend has no knowledge about what this window is for.
Therefore, it has to use other information (window level) to decide
this window is for menu, normal window, modal panel or popup menu.
If there is a information from gui to tell backend
what kind of window it needs,
backend may be able to create a window which behaves better.
Anyway, just a suggestion.

-Deleted Account- <yjchen>
Wed 13 Sep 2006 04:53:26 AM UTC, comment #1: 

Fixed in SVN ... thanks.
Your solution looks best.
You can differentiate between window types by looking at the class of the object ... so I don't thi9nk adding another flag is necessary.

Richard Frith-Macdonald <CaS>
Group Member
Wed 13 Sep 2006 12:07:23 AM UTC, original submission:  

In save panel in Ink.app or Gorm.app,
the popup menu does not work with GNOME or EWMH window manager.
It is because the save panel is declared as modal in xwindow,
but the popup menu is not.
Therefore, the popup menu is always placed under the save panel.
I attach a patch to declare popup menu always modal.
It tricks the window manager to put it in front of a modal window.
Since popup menu disappear when mouse button is released,
declaration of modal does not have real side effect on other windows so far.
Of course, more tests are needed.

Another solution is to have a window level to mark a popup menu
 for a modal window, not a normal window,
ex. GSModalPopupMenuWindowLevel.
Then it can be properly set in backend.

Another suggestion is that it would be nice to have an internal
flag to mark the difference of menu, panel, window, etc.
Currently, it depends on window level,
but I guess it is not what window level is intended to do
since the level can be arteibrary.

By the way, since the GNOME adapts EWMH mostly,
I guess it is not necessary to handle GNOME window manager
separately from EWMH anymore.
It may reduce the maintaince on x11 backend.

-Deleted Account- <yjchen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #10743:  XGServerWindow.m.diff added by yjchen (513B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-09-13 CaS StatusNone Fixed
    Open/ClosedOpen Closed
2006-09-13 yjchen Attached File- Added XGServerWindow.m.diff, #10743

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code