bugGNUstep - Bugs: bug #11600, [NSSavePanel...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #11600: [NSSavePanel -browser:isColumnValid:] doesn't detect missing files

Submitted by:  Alexander Malmberg <alexm>
Submitted on:  Fri 14 Jan 2005 03:53:14 PM UTC  
 
Category: Gui/AppKitSeverity: 2 - Minor
Item Group: BugStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Fri 14 Jan 2005 03:53:14 PM UTC, original submission:

[NSSavePanel -browser:isColumnValid:] currently only checks that all filenames in the column are valid according to the delegate's -panel:shouldShowFilename: method. Thus, it won't notice if there are files in the directory that should be shown but aren't (e.g. because the disk contents changed, or because the delegate's filtering became more permissive).

(Reproduce e.g. with a save panel with a file type popup with entries "All files" and ".txt only". Go to a directory with non-.txt files, switch to ".txt only", switch back to "All files", and the non-.txt files won't be displayed.)

Since this method is only called from -validateVisibleColumns, and since a proper check here involves reading in the directory, building a new list of files, and comparing, I think we might as well return NO always and just reload the column. However, due to NSBrowser internals, this would cause us to lose the selection every time the columns are validated. Probably best to have NSBrowser preserve the selection, though.

(this is "tests/gui/NSSavePanel/setDelegate_reload.m" in the 'new' test suite)

Alexander Malmberg <alexm>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item

Back to the top


Powered by Savane 3.1-cleanup