patchGNU Octave - Patches: patch #7684, minor changes related to save()

 
 

patch #7684: minor changes related to save()

Submitter:  Kris Thielemans <krthie>
Submitted:  Tue 13 Dec 2011 05:23:01 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 14 Dec 2011 07:13:34 PM UTC, comment #1: 

I applied your patches.  I did a small update for style to the Mercurial commit message to match Octave coding conventions.  Thanks for providing a changeset which is easy to work with.  These patches will show up in the impending 3.6.0 release.

Applied here:
http://hg.savannah.gnu.org/hgweb/octave/rev/fafd2f45bfa5
http://hg.savannah.gnu.org/hgweb/octave/rev/8c327d185f5f

Rik <rik5>
Group administrator
Tue 13 Dec 2011 05:23:01 PM UTC, original submission:  

This patch introduces 2 tiny changes

load-save.cc: mention save_header_format_string in the see-also doc-string for save()

pt-assign.cc: change  "default_save_format" to "default_save_options" in former_built_in_variables (default_save_format no longer exists and JWE mentions that default_save_options should have been there)

Kris

PS: this is my first Mercurial experience, so I am not 100% sure if the patch is ok (There's a patch to ls by Rik in this changeset which presumably was committed between my 2 commits). It was obtained using
   hg export -o ../savepatch.diff 14042:b27b5d5768db

Kris Thielemans <krthie>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #24583:  savepatch.diff added by krthie (3KiB - application/octet-stream - mercurial changeset)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by krthie (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-12-14 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2011-12-13 krthie Attached File- Added savepatch.diff, #24583

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code